Skip to content
Snippets Groups Projects

Miscellaneous test coverage work

Merged Miscellaneous test coverage work
nickm/arti:coverage_20220402 into main
1 unresolved thread
Merged Nick Mathewson requested to merge nickm/arti:coverage_20220402 into main
1 unresolved thread

Here are a few tweaks to improve test coverage over a few of our already-well-covered modules. (I tend to write tests when I'm feeling bored or twitchy.)

Merge request reports

Approved by
eta

Merged by etaeta 3 years ago (Apr 4, 2022 2:36pm UTC)

Merge details

  • Changes merged into main with 314f5707.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
crates/tor-rtmock/src/net.rs
55 55 tls_cert: Option<Vec<u8>>,
56 56 }
57 57
58 /// A possible non-error behavior from an address
59 #[derive(Clone)]
60 enum AddrBehavior {
61 /// There's a listener at this address, which would like to reply.
62 Listener(ListenerEntry),
63 /// All connections sent to this address will time out.
64 Timeout,
  • Comment on lines +63 to +64
    eta
    eta @eta ·
    Contributor

    It would be nice to have an even more annoying mode where the connection succeeds but writes and reads either block forever someday.

  • Please register or sign in to reply
  • eta approved this merge request

    approved this merge request

  • eta mentioned in commit 314f5707

    mentioned in commit 314f5707

  • eta merged

    merged

  • eta
    eta @eta ·
    Contributor

    lgtm!

    • Please register or sign in to reply