Skip to content
Snippets Groups Projects

Implement a safe-logging facility.

Merged Nick Mathewson requested to merge nickm/arti:safelogging into main
All threads resolved!

Here we add the "safe logging" feature from C tor, where certain information is suppressed from the logs as "sensitive". We can do a little better than C tor, thanks to Rust's type system.

This branch doesn't yet suppress very much; we can expand it to cover more in the future.

Closes #189 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • eta approved this merge request

    approved this merge request

  • Contributor

    Looks good to me (modulo one very small typo)! (I didn't know about fluid_let; it's cool that someone thought to implement one of the nice Common Lisp features in Rust :p)

    Edited by eta
  • Nick Mathewson resolved all threads

    resolved all threads

  • Nick Mathewson added 1 commit

    added 1 commit

    Compare with previous version

  • Nick Mathewson added 67 commits

    added 67 commits

    • a424cca5...de2b2364 - 62 commits from branch tpo/core:main
    • 7aacc6e3 - Implement a safe-logging facility.
    • 4679023c - Apply `sensitive` in some info-level log messages.
    • 7e34692a - arti: add support for safe-logging configuration
    • b8791256 - Disable safe-logging when logging to console.
    • 373934ef - Punctuation fix.

    Compare with previous version

  • Nick Mathewson enabled an automatic merge when the pipeline for 373934ef succeeds

    enabled an automatic merge when the pipeline for 373934ef succeeds

  • merged the fix, rebased, marked for merge.

  • Nick Mathewson mentioned in commit c302a291

    mentioned in commit c302a291

  • Please register or sign in to reply
    Loading