impl_standard_builder followup (!505) · Merge requests · The Tor Project / Core / Arti

Merged Ian Jackson requested to merge Diziet/arti:builder-default-bis into main 2 years ago

May 12, 2022

Rename impl_standard_builder from impl_default_via_builder · c1c6f2b3

Ian Jackson authored 2 years ago

I have Plans for this macro.  In particular:

 * I have a wip branch which tests that the Builder can be
   deserialised from an empty config (ie, that config reading
   of a config with a blank section for this item works).

 * I think we should autogenerate $Config::builder(),
   and promote that, rather than $ConfigBuilder::default().
   This macro could do that.

c1c6f2b3

config: Replace more handwritten impl Default · 888d6e05
Ian Jackson authored 2 years ago

888d6e05

config: Move macro calls to next to the struct · 400266b2

Ian Jackson authored 2 years ago

This macro is kind of derive-y.  Also it has a test in it, and failing
to call it could allow bugs to exist, as well as missing bits of API.
Putting it next to the structs makes it easy to see that it's actually
been called.

400266b2

impl_standard_builder followup

Merge request reports

Activity