Remove dbg!()s in tor-config, and fix nightly CI

This should satisfy our CI and turn it green again.

(If not, it should remove some of the causes of our CI warnings)

assigned to @nickm

requested review from @Diziet

oops: It looks like there are still more CI errors that the dbg stuff was covering up. Working on those...

changed title from Remove dbg!()s in tor-config to Remove dbg!()s in tor-config, and fix nightly CI

added 1 commit

• 994426d1 - Add a couple of "pub use" to make nightly rustdoc pass.

Compare with previous version

Okay, this time I think CI will be green. What could go wrong?

I think the dbg!s are fine and should stay. They are in tests. I filed this as a clippy false positive upstream: https://github.com/rust-lang/rust-clippy/issues/8758, which was closed by an MR yesterday. Would you mind if we deferred this dbg removal and hope that the nightly-we-are-using gets that fix RSN?

All the dbg! appear to be in the same bloc of tests. An alternative to get green CI is to allow this specific lint for this specific mod tests if we want to keep them

FTAOD: if the not-green-ness of the CI is bothering you, and you prefer to remove the dbg's now, I am OK with you merging this MR as-is. The other change looks good to me.

We can always revert that commit later.

Okay. I'm going to merge this, in that case, since our practice of ignoring this failure has led to us introducing other clippy failures.

merged

mentioned in commit aaa8bfcb