Skip to content

deduplicate dns requests based on transaction id

trinity-1686a requested to merge trinity-1686a/arti:dns-dedup into main

fix #411 (closed)

I think this should be reviewed by @Diziet as they are familiar with DNS (I can't actually assign reviewers).
The behavior is to deduplicate based source IP and transaction ID, and to reply only to the last request (use the port from the last request received, not the first).
This behavior is what pleases dig, as tested by running dig torproject.org @127.0.0.1 -p 5354 +timeout=1 +tries=32, but it's somewhat surprising to me the client port is changing, so maybe it's a quirk of dig?

Merge request reports