Now that x509_get_not{Before,After} are functions in OpenSSL 1.1
(not yet releasesd), we need to define a variant that takes a const
pointer to X509 and returns a const pointer to ASN1_time.

Part of 17237. I'm not convinced this is an openssl bug or a tor
bug. It might be just one of those things.

teor (Tim Wilson-Brown) authored 9 years ago and Nick Mathewson committed 9 years ago

Ensure that either a valid address is returned in address pointers,
or that the address data is zeroed on error.

Ensure that free_interface_address6_list handles NULL lists.

Add unit tests for get_interface_address* failure cases.

Fixes bug #17173.
Patch by fk/teor, not in any released version of tor.

Fabian Keil authored 9 years ago and Nick Mathewson committed 9 years ago

... that was removed by 31eb486c which first appeared in
0.2.7.3-rc.

If tor is running in a ElectroBSD (or FreeBSD) jail it can't
get any IP addresses that aren't assigned to the jail by
looking at the interfaces and (by design) the
get_interface_address6_via_udp_socket_hack() fallback doesn't
work either.

The missing return code check resulted in tor_addr_is_internal()
complaining about a "non-IP address of type 49", due to reading
uninitialised memory.

Fixes #17173.

Marcin Cieślak authored 9 years ago and Nick Mathewson committed 9 years ago

BSD make takes spaces around = literally
and produces a "TESTING_TOR_BINARY "
variable with a trailing space, which leads
to test_keygen.sh failure.

Fixes 17154

Marcin Cieślak authored 9 years ago and Nick Mathewson committed 9 years ago

FreeBSD needs -lexecinfo to fully support
backtrace reporting.

FreeBSD make demands this.

Fixes bug 17149; bug not in any released Tor.

Use environment variables instead. This repairs 'make distcheck',
which was running into trouble when it tried to chmod the generated
scripts.

Fixes 17148.

Implements ticket #17135.  We're going to need this one to avoid
chaos as everybody figures out how ed25519 keys work.

We're about to need to call it in another place too.