Since 0.2.4.11-alpha (in 01966479) we've tried to randomize
the start time to up to some time in the past.  But unfortunately we
allowed the start time to be in the future as well, which isn't
really legit.

The new behavior lets the start time be be up to
MAX(cert_lifetime-2days, 0) in the past, but never in the future.

Fixes bug 21420; bugfix on 0.2.4.11-alpha.

This ensures we reliably call chutney's newer tools/test-network.sh when
available.

Fixes bug 21562; bugfix on tor-0.2.9.1-alpha.

Part of 21570.

Requires the chutney changes from 21572.
(Otherwise, asks users to upgrade their chutney.)

Implements 21570.

Teor thinks that this connection_dirserv_add_dir_bytes_to_outbuf()
might be the problem, if the "remaining" calculation underflows.  So
I'm adding a couple of checks there, and improving the casts.

Possible fix or diagnostic for 21369.

Requires the equivalent chutney changes in 21571.

Part of 21570.

David Goulet authored 8 years ago and Nick Mathewson committed 8 years ago

When encoding a legacy ESTABLISH_INTRO cell, we were using the sizeof() on a
pointer instead of using the real size of the destination buffer leading to an
overflow passing an enormous value to the signing digest function.
Fortunately, that value was only used to make sure the destination buffer
length was big enough for the key size and in this case it always was because
of the overflow.

Fixes #21553

Signed-off-by: David Goulet <dgoulet@torproject.org>

scan-build found that we we checking UseEntryGuards twice.

Fixes bug 21492.

Bug found with clang scan-build.  Fixes bug on f63e06d3.
Bug not present in any released Tor.

Fix on fc58c37e. Not in any released tor

This patch makes us store the number of sent and received RELAY_DATA
cells used for directory connections. We log the numbers after we have
received an EOF in connection_dir_client_reached_eof() from the
directory server.

Instead of returning 404 error code, this led to a NULL pointer being used and
thus a crash of tor.

Fixes #21471

Signed-off-by: David Goulet <dgoulet@torproject.org>

Closes 21450; patch from teor.