Fixes bug 25474; bugfix on 0.3.2.5-alpha.

Alexander Hansen Færøy authored 7 years ago and Nick Mathewson committed 7 years ago

See: https://bugs.torproject.org/25378

"ours" merge to avoid version bump.

"ours" merge to avoid version bump

"ours" merge to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" merge to avoid version bump.

These were meant to demonstrate old behavior, or old rust behavior.

One of them _should_ work in Rust, but won't because of
implementation details.  We'll fix that up later.

The C code and the rust code had different separate integer overflow
bugs here.  That suggests that we're better off just forbidding this
pathological case.

Also, add tests for expected behavior on receiving a bad protocol
list in a consensus.

Fixes another part of 25249.

Fixes part of 24249; bugfix on 0.2.9.4-alpha.

These are as Teor wrote them; I've disabled the ones that don't pass
yet, with XXXX comments.

I've refactored these to be a separate function, to avoid tricky
merge conflicts.

Some of these are disabled with "XXXX" comments; they should get
fixed moving forward.

This one can only be exploited if you can generate a correctly
signed consensus, so it's not as bad as 25074.

Fixes bug 25251; also tracked as TROVE-2018-004.

In some cases we had checked for it, but in others we had not.  One
of these cases could have been used to remotely cause
denial-of-service against directory authorities while they attempted
to vote.

Fixes TROVE-2018-001.