cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

The header includes compat.h which already defines inline.

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

The INLINE keyword is not used anymore in favor of inline.

Windows only supports __inline so an inline preprocessor definition is
still needed.

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

This patch was generated using;

  sed -i -e "s/\bINLINE\b/inline/" src/*/*.[ch] src/*/*/*.[ch]

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

The AM_TESTS_ENVIRONMENT variable is available since Automake v1.12 but
some distributions have older Automake versions so we use
TESTS_ENVIRONMENT.

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

Using variables removes the ambiguity about when to use variables and
when to use substitutions. Variables always work. Substitutions only
work when Autoconf knows about them which is not always the case.

The variables are also placed between quotes to ensures spaces in the
variables are handled properly.

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

Using the AM_TESTS_ENVIRONMENT variable ensures the environment
variables are only set during test execution and not during the
compilation phase.

patch from rubiate on #16651

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

The internal memory allocation and history object counters of the
reputation code can be used to verify the correctness of (part of) the
code. Using these counters revealed an issue where the memory allocation
counter is not decreased when the bandwidth arrays are freed.

A new function ensures the memory allocation counter is decreased when a
bandwidth array is freed.

This commit also removes an unnecessary cast which was found while
working on the code.

  * Use smartlist_foreach_begin/end instead of a plain for loop.
  * constify the pointers.

   * Since the variable is no longer modified, it should be called
     'policy' instead of 'dest'.  ("Dest" is short for
     "destination".)
   * Fixed the space issue that dgoulet found on the ticket.
   * Fixed the comment a little. (We use the imperative for function
     documentation.)