For now, this module is enabled whenever the relay module is
enabled, and disabled whenever the relay module is disabled.  Though
they are logically separate, the use cases for running one without
the other are rare enough that we don't really want to support
compiling them independently.

Taylor Yu authored 5 years ago and Nick Mathewson committed 5 years ago

Move some SafeSocks-related options near each other.  Part of ticket
32846.

Taylor Yu authored 5 years ago and Nick Mathewson committed 5 years ago

Move ReducedCircuitPadding and ReducedConnectionPadding immediately
after the corresponding non-Reduced options.  Part of ticket 32846.

Taylor Yu authored 5 years ago and Nick Mathewson committed 5 years ago

Only directory authorities use the GuardfractionFile option, so move
it to that section.  Part of ticket 32846.

Swati Thacker authored 5 years ago and Nick Mathewson committed 5 years ago

Alphabetize client options in tor.1.txt.  Closes ticket32846.

Patch from opara.  Closes ticket 32779.

We stopped looking at this option in 85cf6dcb, back when we
implemented the minimal pieces of prop275.  Since then, we've had
code to validate and adjust this option, and to give it a different
value in testing networks, but the option hasn't actually done
anything.

We can safely mark it as OBSOLETE, since doing so does not make any
old configuration get rejected.

Closes ticket 32807.

Fix some quoting, especially of constructs like "[address:]port", that
were proving tricky for Asciidoctor tooling to parse correctly.

Also fix formatting of some configuration variable names that
contained double underscores.  Neither asciidoc nor asciidoctor was
rendering some of those correctly.

Part of ticket 32708.

Change the section title formatting to use the one-line format.  This
allows Asciidoctor-based tooling to parse it more easily.

Part of ticket 32708.

Indent the asciidoc markup for lone linebreaks to match the preceding
paragraph line, so that Asciidoctor tools can format them correctly.

Part of ticket 32708.

These are unrelated changes done by Swati while doing the alphabetizing.

Part of ticket 32708.

Swati Thacker authored 5 years ago and Taylor Yu committed 5 years ago

Part of ticket 32708.

* 2 newlines before ====== headers
* 1 newline before ------ headers

And remove a duplicate description of the format.

Obviously correct changes to documentation.

If ExtendedErrors is set for the SocksPort, an invalid .onion address now
returns the 0xF6 error code per prop304.

Closes #30022

Signed-off-by: David Goulet <dgoulet@torproject.org>

In #26913 we solved a bug where CacheDirectoryGroupReadable would
override DataDirectoryGroupReadable when the two directories are the
same.  We never did the same for KeyDirectory, though, because
that's a rare setting.

Now that I'm testing this code, though, fixing this issue seems
fine.  Fixes bug #27992; bugfix on 0.3.3.1-alpha.

Signed-off-by: David Goulet <dgoulet@torproject.org>

The src/feature directory documentation now covers this better.

Closes ticket 32467.

Closes ticket 32406.

This sheet tries to make links to the source code browser less obtrusive.