New approach, suggested by Taylor: During testing builds, we
initialize a union member of an appropriate pointer type with the
address of the member field we're trying to test, so we can make
sure that the compiler doesn't warn.

My earlier approach invoked undefined behavior.

David Goulet authored 7 years ago and Nick Mathewson committed 7 years ago

Fixes #23539.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Just making sure that added padding does not screw up cell parsing.

setup_capture_of_logs() doesn't actually suppress warnings :p

David Goulet authored 7 years ago and Nick Mathewson committed 7 years ago

Fixes #23610

Signed-off-by: David Goulet <dgoulet@torproject.org>

Relays send it, and we may as well let them.  Part of our fix for
22805.

Also, allow channel_is_client() to take a const channel.

The is_first_hop field should have been called used_create_fast,
but everywhere that we wanted to check it, we should have been
checking channel_is_client() instead.

The diff is confusing, but were two static scheduler functions that
needed moving to static comment block.

No code change. Thanks dgoulet for original commit

Closes 23552. Thanks dgoulet for original impl

'check-changes' is now part of "make check", and must pass.

To do this, we had to make sure it passes when the changes directory
is empty.  I also tried to improve the quality of the output, and
fix some false-positive cases.  Let's see how this goes!

Closes ticket 23564.

Fixes bug 21800; bugfix on 0.2.9.x

David Goulet authored 7 years ago and Nick Mathewson committed 7 years ago

Fixes #23610

Signed-off-by: David Goulet <dgoulet@torproject.org>