connection_mark_all_noncontrol_connections() handles orconns wrongly
This should call the right connection_or_close_*() function rather than connection_mark_for_close(). This can readily be observed by starting a client and letting it open some channels, then adding DisableNetwork 1 to the config and reloading, leading to warnings in the log like this:
Mar 24 16:21:16.000 [warn] connection_mark_for_close_(): Something tried to close an or_connection_t without going through channels at src/or/connection.c:2343
Mar 24 16:21:58.000 [warn] connection_mark_for_close_(): Something tried to close an or_connection_t without going through channels at src/or/connection.c:2343
Created pursuant to connection_mark_for_close() audit task legacy/trac#7472 (moved).