DirAuthority IPv6

When I try set DirAuthority to IPv6 like that:

DirAuthority xxxxx orport=5000 no-v2  v3ident=xxxxxxxxxxxxxxxxxxx [xxx:xxxx:xxxx:xxxx:xxxx:xxxxx:xxxx:xxxx]:7000 fingerxxxxxxxxxxxxxxxxxxxxxxxxxxxx

I see error in stdout: Oct 12 16:04:44.091 [warn] Unrecognized flag

Oct 12 16:04:44.091 [warn] Unrecognized flag '[xxx:xxxx:xxxx:xxxx:xxxx:xxxxx:xxxx:xxxx]:7000' on DirAuthority line
Oct 12 16:04:44.091 [warn] Unrecognized flag 'fingerxxxxxxxxxxxxxxxxxxxxxxxxx' on DirAuthority line

Trac:
Username: svirus

changed milestone to %Tor: 0.2.8.x-final in legacy/trac

added component::core tor/tor in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.2.8.x-final in Legacy / Trac parent::17811 in Legacy / Trac priority::medium in Legacy / Trac reporter::svirus in Legacy / Trac resolution::implemented in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels

Trac:
Username: svirus
Severity: N/A to Normal
Component: - Select a component to Tor
Priority: Medium to High

DirAuthority lines currently don't support IPv6.

This is part of the changes in legacy/trac#6027 (moved).

Trac:
Parent: N/A to legacy/trac#6027 (moved)

Trac:
Parent: legacy/trac#6027 (moved) to N/A

See nickm/bug6027_rebased for code that might be useful here.

Trac:
Keywords: N/A deleted, ipv6 added
Parent: N/A to legacy/trac#17811 (moved)

Please see my branch feature17327-v2 on https://github.com/teor2345/tor.git

It contains:

• 616cfb72bf: a rebased 043874ee2e from nickm/bug6027_rebased
  • Add a new ipv6=address:orport flag to DirAuthority and FallbackDir
  • tor.1.txt required a manual merge to update to the latest man page layout
• a53ebf3a9b: Authorities on IPv6: minor fixes and unit tests
• 9dd5ef2480: Add IPv6 addresses & orports to the default directory authorities
• 61a1ead790: Document IPv4 and IPv6 DirPorts
  • Tor assumes that the IPv4 dirport is also available on the relay's IPv6 address. (Or, at least, it will when I'm done.)

The unit tests check that:

• IPv6 and non-IPv6 authorities and fallbacks work
• the default authorities and fallbacks load correctly

These changes are compatible with the latest code in legacy/trac#15775 (moved) - feature15775-fallback-v9. When this code is run on the list of fallback directories attached to legacy/trac#15775 (moved), they all parse correctly.

Please note that Tor doesn't use these new IPv6 addresses and ports yet. (legacy/trac#17281 (moved) will modify Tor clients to use these new IPv6 addresses to bootstrap.)

Trac:
Status: new to needs_review
Milestone: N/A to Tor: 0.2.8.x-final
Type: defect to enhancement
Priority: High to Medium

I have updated this branch to unit test parsing an authority line and a fallback line, with and without an IPv6 flag. I've also removed a comment typo fix that had nothing to do with the patch.

See my branch feature17327-v3:

• a53ebf3a9b has been modified to cf6e221bd8
• all other commits are the same (but the hashes of subsequent commits have changed)

(Also added a changes file as another commit to feature17327-v3.)

The commits on this branch didn't rebase correctly onto master. I've rebased the branch and squashed the changes file and some fixups.

Please see feature17327-v4:

• Add a new ipv6=address:orport flag to DirAuthority and FallbackDir
  • a rebased 043874ee2e from nickm/bug6027_rebased
  • tor.1.txt required a manual merge to update to the latest man page layout and context
• Authorities on IPv6: minor fixes and unit tests
• Add IPv6 addresses & orports to the default directory authorities
  • If they have them in their descriptor on Globe

(I dropped "Document IPv4 and IPv6 DirPorts", as it belongs in legacy/trac#17840 (moved) where those changes are actually being made.)

Code looks good to me. If I understand correctly, this would mean that clients know ipv6 addresses for fallbacks and authorities ... but not that they'd actually be able to use them yet. Am I right or missing something?

Replying to nickm:

Code looks good to me. If I understand correctly, this would mean that clients know ipv6 addresses for fallbacks and authorities ... but not that they'd actually be able to use them yet. Am I right or missing something?

Yes, the directory code only considers IPv4 addresses at the moment. I'm working on making it consider IPv6 addresses in legacy/trac#17840 (moved).

But feature17327-v4 can merge in the interim, as any features that relate to authorities/fallbacks on IPv6 depend on the ipv6 fields this patch provides.

(In particular, I'd like to see legacy/trac#16774 (moved) revised to display authority and fallback IPv6 addresses. It depends on this feature being merged.)

Right, that sounds fine. Merging feature17327-v4

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

closed

mentioned in issue legacy/trac#17774 (moved)

mentioned in issue legacy/trac#17817 (moved)

mentioned in issue legacy/trac#17840 (moved)

moved from legacy/trac#17327 (moved)

added Feature label and removed 1 deleted label

added IPv6 label and removed 1 deleted label