Extract the authority list from config.c

There is a list of default_authorities in src/or/config.c. We want it in a separate file at src/or/auth_dirs.inc.

This should be implemented like the default_fallbacks array, which includes the fallback list from src/or/fallback_dirs.inc.

We will need to implement two branches for backporting:

• a branch on maint-0.2.9 for 0.2.9 and later. It has IPv6 addresses.
• a branch on maint-0.2.5 for 0.2.5. It has no IPv6 addresses.

(Then, after we have moved it into a separate file, we want to automatically generate the file, in a new format. See the rest of the children of legacy/trac#24818 (moved).)

changed milestone to %Tor: 0.3.4.x-final in legacy/trac

added 029-backport in Legacy / Trac 031-backport in Legacy / Trac 032-backport in Legacy / Trac 033-backport in Legacy / Trac 034-triage-20180328 in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.4.x-final in Legacy / Trac parent::24818 in Legacy / Trac points::0.2 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac review-group-32 in Legacy / Trac review-group-33 in Legacy / Trac review-group-34 in Legacy / Trac reviewer::ahf in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tor-dirauth in Legacy / Trac torspec in Legacy / Trac type::enhancement in Legacy / Trac labels

Trac:
Username: beastr0
Cc: N/A to beastr0@protonmail.com

Should this function/method (can't remember which one it's called in C) be written in the config.c file or somewhere else?

Trac:
Username: beastr0

I don't think we need to modify any functions for this patch.

This patch should #include "auth_dirs.inc" in config.c at compile time, like we do a few lines later in config.c with "fallback_dirs.inc".

(Sorry, that wasn't very obvious.)

I've been crawling through the files, just getting myself oriented, and I think I see where I went wrong. Ha, wow, nice and easy fix. Should I also create the auth_dirs.inc file or is that legacy/trac#24853 (moved)?

Trac:
Username: beastr0

Please create the file by copying and pasting the current contents of the array. Then we can modify the format of the file in legacy/trac#24851 (moved), and backport it in legacy/trac#24853 (moved).

We won't backport this to 0.2.5, because the format is missing ipv6. Instead, we will manually backport any authority changes that happen before May 2018 when 0.2.5 is EOL.

Trac:
Keywords: 025-backport deleted, N/A added

Trac:
Description: There is a list of default_authorities in src/or/config.c. We want it in a separate file at src/or/auth_dirs.inc.

This should be implemented like the default_fallbacks array, which includes the fallback list from src/or/fallback_dirs.inc.

We will need to implement two branches for backporting:

• a branch on maint-0.2.9 for 0.2.9 and later. It has IPv6 addresses.
• a branch on maint-0.2.5 for 0.2.5. It has no IPv6 addresses.

(Then, after we have moved it into a separate file, we want to automatically generate the file, in a new format. See the rest of the children of legacy/trac#24818 (moved).)

to

There is a list of default_authorities in src/or/config.c. We want it in a separate file at src/or/auth_dirs.inc.

This should be implemented like the default_fallbacks array, which includes the fallback list from src/or/fallback_dirs.inc.

We will need to implement two branches for backporting:

• a branch on maint-0.2.9 for 0.2.9 and later. It has IPv6 addresses.
• a branch on maint-0.2.5 for 0.2.5. It has no IPv6 addresses.

(Then, after we have moved it into a separate file, we want to automatically generate the file, in a new format. See the rest of the children of legacy/trac#24818 (moved).)

We have time to do these, let's do them well in 0.3.4

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.4.x-final

So Teor (or anyone else who's reading this and knows), how and where do I upload these patches?

Trac:
Username: beastr0

You can attach them to this ticket using the "Attachments" button near the top of the ticket. (If you don't see it, let me know, and I will enable it for you.)

Or you can clone https://git.torproject.org/tor.git , create a new branch, commit the patches to that branch, and push the branch to GitHub or a similar public repository.

Trac:
Username: beastr0

config.c

24854 edit to config.c

Trac:
Username: beastr0

Hi, can you also upload a copy of the auth_dirs.inc file?

We usually use the "diff" command to produce a small patch file containing all the changed files. If you would like, you can also upload a patch file containing the changes to config.c, and the new auth_dirs.inc file.

Trac:
Status: new to needs_revision
Keywords: 030-backport deleted, N/A added

Trac:
Username: beastr0

auth_dirs.inc

dependency for 24854 edit to config.c

Trac:
Username: beastr0

This looks good to me.

I still need to:

• check that the authority information is exactly the same,
• run the unit tests, and
• put the changed code into a branch.

Trac:
Status: needs_revision to needs_review

Trac:
Username: beastr0

config_c.patch

patch file of config.c for 0.3.4

Trac:
Username: beastr0

Do you need any help with those tasks? or do you have any other specific tickets that you would like me to work on?

Trac:
Username: beastr0

Replying to beastr0:

Do you need any help with those tasks? or do you have any other specific tickets that you would like me to work on?

Ticket legacy/trac#24851 (moved) is the next step: we want to generate the auth_dirs.inc file using a script. That way, we can update it automatically when authority details change. If you know python, or you're willing to learn, it's a good ticket.

Otherwise, I'm not actively working on anything in C at the moment, but I'll let you know. Or you can look for tickets.

Yeah, sure, I can take that one on. I know Python, C and Java so for future reference you guys can hit me up with any projects based on those languages.

Trac:
Username: beastr0

(teor, it sounds like you'd like me to mark you reviewer on this one. please let me know if that's not right.)

Trac:
Reviewer: N/A to teor

Trac:
Keywords: N/A deleted, review-group-32 added

Trac:
Keywords: N/A deleted, review-group-34 added

Trac:
Keywords: review-group-34 deleted, review-group-33 added

Trac:
Keywords: N/A deleted, review-group-34 added

Trac:
Keywords: N/A deleted, 034-triage-20180328 added

In Rome, we decided on a 1 week deadline for reviews. I'm not going to get time review this, so it should be assigned to someone else.

To review:

• make sure that the code compiles
• make sure that the authority details were moved between files, without being changed

Trac:
Reviewer: teor to N/A

Reviewer assignment for week 02/04/2018

Trac:
Reviewer: N/A to ahf

Hey beastr0,

Thanks for your patches. I think they look good, but it's not possible for us to integrate them right now in the current form as we need them in a Git patch format. I can do this for you if you want me to.

Otherwise you can do this yourself as it will make the life of the patch reviewers much easier: create a branch in Git with your changes in, do a git add <file> for each <file> you have modified, then do git commit and write a commit message. For Tor we normally also want a 'changes' file that describes the change for use in ChangeLog messages when we make the release. Once this is done you can push your branch to, for example, Github and post a link here for where we can review it :-)

We have some documentation on this process here: https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStarted.md

Unless I hear back from you, I will proceed with turning your changes into a Git style patch and credit you as beastro0 in the ChangeLog entry!

Thanks

Trac:
Status: needs_review to needs_revision

The patches have been combined in https://github.com/torproject/tor/pull/43

Trac:
Status: needs_revision to needs_review

Looks good to me! As long as it unit tests fine, and tor bootstraps on the public network, we should be good here.

Trac:
Status: needs_review to merge_ready

Oh, this branch needs to be based on 0.2.9, because it will be backported to 0.2.9, 0.3.1, 0.3.2, and 0.3.3.

Trac:
Status: merge_ready to needs_revision
Keywords: N/A deleted, 033-backport added

Pushed new version to https://github.com/torproject/tor/pull/43 (based of on master). The new version have the auth_dirs.inc file added to the set of included files when we make releases (ORHEADERS in this case).

I opened https://github.com/torproject/tor/pull/44 which is based of on maint-0.2.9.

Trac:
Status: needs_revision to needs_review

Lets get it merged

Trac:
Status: needs_review to merge_ready

Merged to 0.2.9 and forward. Pfew! Good work, everybody!

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

changed time estimate to 1h 36m

mentioned in issue legacy/trac#25534 (moved)

mentioned in issue legacy/trac#25538 (moved)

moved from legacy/trac#24854 (moved)

added Feature label and removed 1 deleted label

added Authority Specifications labels and removed 1 deleted label

mentioned in issue #24818 (closed)