Manual includes non-existant ExitPolicyDefault option

Back in November I made a few manual fixes which included making its ExitPolicyDefault line visible...

https://gitweb.torproject.org/tor.git/commit/?id=3563a2c

On reflection the tor codebase doesn't look to include any such option. If it wasn't for a torrc option then I'm unsure what ExitPolicyDefault was in reference to...

Most likely we should just drop it from the manual.

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

added 033-included-20180403 in Legacy / Trac component::core tor/tor in Legacy / Trac fast-fix in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::nickm in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::dgoulet in Legacy / Trac severity::minor in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac labels

Have a look at the state before 3563a2c8 -- I think that it was meant to be an anchor only, with no label.

Gotcha. Is such an anchor useful? I just did a quick grep of webwml but no hits. An anchor seems pretty boot if nothing links to it.

let's leave the anchor in -- somebody may be using it, and I'd rather not remove anchors once we've added them, unless they're completely pointless.

Oh! Did a little more looking and it's not there to provide an anchor at all. Rather, it's a hack so the following text is formatted as a paragraph. This is discussed in legacy/trac#20885 (moved).

Sure, reverting that line back to an anchor sounds good. Preferably with a comment above that, the SocksPortFlagsMisc, and ORPortFlagsExclusive (if they're still around) to explain that these are formatting hacks rather than intentional anchors.

Trac:
Status: new to accepted
Keywords: N/A deleted, fast-fix added
Milestone: N/A to Tor: 0.3.3.x-final
Owner: N/A to nickm

Fix in bug25582_033

Trac:
Status: accepted to needs_review

LGTM, though again I think this (and the other options mentioned above) should be accompanied by a comment saying that they're formatting hacks so it's clear they're not intended to be a torrc option.

Reviewer assignment for week 02/04/2018

Trac:
Reviewer: N/A to dgoulet

Trac:
Keywords: N/A deleted, 033-included-20180403 added

To address atagar's comment about having a mention about the formatting hacks, I've added a commit that does that to all options like this one:

See branch: bug25582_033 (based on nickm's from above).

This is ready to merge imo.

Trac:
Status: needs_review to merge_ready

Looks great to me! Thanks David.

merged to 0.3.3 and forward!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved from legacy/trac#25582 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label