Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,067
    • Issues 1,067
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 20
    • Merge Requests 20
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor
  • Merge Requests
  • !140

Merged
Opened Sep 07, 2020 by George Kadianakis@asnOwner

statistics: Properly count all rendezvous cells (avoid undercounting). [035+]

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 2

tl;dr We were not counting cells flying from the client to the service, but we were counting cells flying from the service to the client.

When a rendezvous cell arrives from the client to the RP, the RP forwards it to the service.

For this to happen, the cell first passes through command_process_relay_cell() which normally does the statistics counting. However because the rend_circ circuit was not flagged with circuit_carries_hs_traffic_stats in rend_mid_rendezvous(), the cell is not counted there.

Then the cell goes to circuit_receive_relay_cell() which has a special code block based on rend_splice specifically for rendezvous cells, and the cell gets directly passed to rend_circ via a direct call to circuit_receive_relay_cell(). The cell never passes through command_process_relay_cell() ever again and hence is never counted by our rephist module.

The fix here is to flag the rend_circ circuit with circuit_carries_hs_traffic_stats so that the cell is counted as soon as it hits command_process_relay_cell().

Furthermore we avoid double-counting cells since the special code block of circuit_receive_relay_cell() makes us count rendezvous cells only as they enter the RP and not as they exit it.

Fixes #40117 (closed).

Edited Sep 07, 2020 by George Kadianakis
Assignee
Assign to
Reviewer
Request review from
Tor: 0.3.5.x-final
Milestone
Tor: 0.3.5.x-final
Assign milestone
Time tracking
Reference: tpo/core/tor!140
Source branch: bug40117_035