config: Really ignore non ORPorts when removing duplicates

The function in charge of removing duplicate ORPorts from our configured ports was skipping all non ORPorts port but only for the outer loop thus resulting in comparing an ORPort with a non-ORPort which lead to problems.

For example, tor configured with the following would fail:

ORPort auto DirPort auto

Both end up being the same configuration except that one is a OR listener and one is a Dir listener. Thus because of the missing check in the inner loop, they looked exactly the same and thus one is removed.

Fixes #40195 (closed)

Signed-off-by: David Goulet dgoulet@torproject.org