Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 824
    • Issues 824
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Merge requests
  • !475

Fix Windows build for 0.3.5

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexander Færøy requested to merge ahf/tor:ahf/035_40275 into maint-0.3.5 Oct 29, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

This is a 0.3.5 backport of #40275 (closed).

While trying to resolve our CI issues, the Windows build broke with an unused function error:

src/test/test_switch_id.c:37:1: error: ‘unprivileged_port_range_start’ defined but not used [-Werror=unused-function]

We solve this by moving the #if !defined(_WIN32) test above the unprivileged_port_range_start() function defintion such that it is included in its body.

This is an unreviewed commit.

See: #40275 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ahf/035_40275