Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 311
    • Issues 311
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 33
    • Merge requests 33
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Merge requests
  • !597

Remove ext_or_conn_id and connection_or_remove_from_ext_or_id_map

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Alex Xu requested to merge Hello71/tor:remove-ext_or_conn_id into main Jun 29, 2022
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 4

gcc 12 correctly complains that connection_or_set_ext_or_identifier copies from uninitialized memory. Since the result is never read, remove the function and struct member.

Fixes: d1494d14 ("Remove orconn_ext_or_id_map and related functions")

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove-ext_or_conn_id