Fix: bw cache entry spikes (Issue: #31524)

Fixes the issue with bandwidth cache spikes on controller connection.

Related issue: #31524 (closed).

requested review from @dgoulet

changed milestone to %Tor: 0.4.9.x-freeze

changed target branch from main to maint-0.4.1

changed target branch from maint-0.4.1 to maint-0.4.8

changed target branch from maint-0.4.8 to main

Target the branch for inclusion, in this case main considering we are aiming 0.4.9. Thanks!

What I'm wondering is if we should only set it if 0 and if not, leave it the way it is because another control connection could have set stats_prev_n_read/write.

So a new control auth would likely advance that value meaning control_get_bytes_rw_last_sec() would set a smaller n_read then what it should be?

resolved all threads

added 1 commit

• c476ebf3 - Fix: control events - bw cache spikes

Compare with previous version

added 1 commit

• 6f297e0d - Fix: control events - bw cache spikes

Compare with previous version

resolved all threads

changed the description

added 2 commits

• 93df26b1 - 1 commit from branch tpo/core:main
• 29603cdc - Fix: control events - bw cache spikes

Compare with previous version

changed the description

changed target branch from main to maint-0.4.8

Rebased from main onto maint-0.4.8 branch.

I've tested this fix with cookie authentication method only.
Probably it won't work with other auth methods.
I'll verify and change it to work with other methods too if changes are needed.

added 258 commits

• 29603cdc...08e872ef - 15 commits from branch tpo/core:maint-0.4.8
• 08e872ef...e5b51eb1 - 233 earlier commits
• 717b59ac - process: Don't close all FDs on new spawn
• 5567617e - Merge branch 'ticket40990_049_01' into 'main'
• 9918acd5 - release: ChangeLog and ReleaseNotes for 0.4.9.1-alpha
• 132e6aad - version: Bump version to 0.4.9.1-alpha
• ff34bbf4 - version: Bump version to 0.4.9.1-alpha-dev
• 1e46ba5b - remove the 0.4.9.1-alpha entries from releasenotes
• 07777d96 - forward-port the 0.4.8.13 changes
• 997b151b - remove redundant change entries
• a789ab32 - Merge branch 'fix-changelogs' into 'main'
• ac2529f1 - Fix: control events - bw cache spikes

Compare with previous version

changed the description

changed target branch from maint-0.4.8 to main

closed

reopened

resolved all threads

• Rebased back onto main
• Fixed: Crash when authentication fails on single controller connection

approved this merge request

merged

mentioned in commit b9907f78