Skip to content
Snippets Groups Projects

Draft: bandwidth-file: Add ratios KeyValues in RelayLines

Closed Draft: bandwidth-file: Add ratios KeyValues in RelayLines
juga/torspec:issue210 into main
2 unresolved threads
Closed juga requested to merge juga/torspec:issue210 into main
2 unresolved threads

and network bandwidth averages KeyValues in the Header. Closes #210 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
bandwidth-file-spec.txt
140 142 version_number
141 143
142 144 We define the following nonterminals:
143
145 Float
  • Georg Koppen
    Georg Koppen @gk started a thread on an old version of the diff
    • bandwidth-file-spec.txt
    519 521 This Line was added in version 1.4.0 of this specification.
    520 522
    523 "mu" Int NL
    524
    525 [Zero or one time.]
    526
    527 The network stream bandwidth average calculated as explained in B4.2.
    528
    529 This Line was added in version 1.7.0 of this specification.
    530
    531 "muf" Int NL
    532
    533 [Zero or one time.]
    534
    535 The network stream bandwidth average filtered calculated as explained in
    536 B4.4.
  • Georg Koppen
    Georg Koppen @gk ·
    Reporter

    Two nits (while the second one is actually a question), the rest looks good.

  • Alexander Hansen Færøy
    Alexander Hansen Færøy @ahf ·
    Owner

    Will merge once nits are resolved :-)

  • juga added 1 commit

    added 1 commit

    • 3db8bea2 - fixup! bandwidth-file: Add ratios KeyValues in RelayLines

    Compare with previous version

  • juga marked this merge request as draft from juga/torspec@3db8bea2

    marked this merge request as draft from juga/torspec@3db8bea2

  • juga
    juga @juga ·
    Author Reporter

    Squashed at !149 (merged)

  • juga mentioned in merge request !149 (merged)

    mentioned in merge request !149 (merged)

  • Georg Koppen
    Georg Koppen @gk ·
    Reporter

    @ahf: we are good here. Please close this MR and use !149 (merged) which has everything squashed.

  • Alexander Hansen Færøy
    Alexander Hansen Færøy @ahf ·
    Owner

    Sounds good :thumbsup:

  • Alexander Hansen Færøy closed

    closed

    • Please register or sign in to reply