IntegerDistribution breaks when given negative values

As found in legacy/trac#27981 (moved), our unit tests fail when being run in 1990.

The reason is that we're using a hard-coded time for sending the request (2013-04-24 12:22:22) and the current system time for determining when we handled the request. We compute the difference of the two timestamps as the time needed for handling the request. But IntegerDistribution does not accept negative values.

That's a bug. It should either reject negative values in its addLong method, or it should store them and include them in the result. I'd prefer the second variant, even though we're not using it for negative values under normal circumstances.

Not blocking the upcoming 8.0 protocol update.

added component::metrics/onionoo in Legacy / Trac owner::metrics-team in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac labels

Please review commit c0a3a11 in my task-33360 branch.

Trac:
Status: new to needs_review

This trivial (and tested!) patch can as well go in without review. Setting to merge_ready, will merge as time permits.

Trac:
Status: needs_review to merge_ready

Merged. Closing.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved from legacy/trac#33360 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label