Thanks for the patch, sorry it took us a while to get back to it!

I'm trusting you when you say it works, so I've just justified the changes to the 80 column limit and opened a MR for you (!902 (merged)).

Thank you for the MR! I can confirm that 13.5 nightly still builds on a brand new Fedora 39 installation with those dependencies installed (I just tried), plus make and patch.

I didn't mention it when I opened the issue, I didn't include make and patch among the Fedora dependencies because the Debian/Ubuntu and Arch entries don't and the README specifically says you can install them with, referring to what's written previously - and that doesn't include them as well. make should not be a problem since that's the first command you run, so you'll immediately recognize you have to install it to do anything. Not knowing that you also need patch, on the other hand, could be annoying, since that's first needed only when building llvm, and if you don't have patch installed the build will fail halfway through. I'll let you decide whether make and patch need to be added or not (after all, if you're building the Tor Browser, it is likely that you already have them).

One note, though: while formatting the dependencies to 80 columns, you forgot a backslash on line 57. If someone copy-pastes the command like I just did, it will fail to install the remaining dependencies. So this should perhaps be fixed.

you forgot a backslash on line 57

Ouch, I thought I fixed that!

since that's first needed only when building llvm

Normally we run stuff in containers for many reasons. But llvm-project doesn't, because it's just creating a source code archive.

Or, it was, until last Summer, then I had to add a couple of patches for reproducibility.

I think we could just add patch to the list of requirements. It's much smaller than git, mercurial and so on.

Running git apply instead of patch is another alternative (git apply doesn't need the information about the git repository, and you must have git for sure).

if you're building the Tor Browser, it is likely that you already have them

Yep, I think we do have them also in the build machines because a few packages can be built without containers (esp. the signing tools).

And I think patch is installed by default on Debian, not sure why.

Good, if you want me to write another patch ask away!

since that's first needed only when building llvm

Normally we run stuff in containers for many reasons. But llvm-project doesn't, because it's just creating a source code archive.

Or, it was, until last Summer, then I had to add a couple of patches for reproducibility.

I think we could just add patch to the list of requirements. It's much smaller than git, mercurial and so on.

Running git apply instead of patch is another alternative (git apply doesn't need the information about the git repository, and you must have git for sure).

I think adding patch and make to the list of dependencies is a good idea. Maybe also for Debian.

if you're building the Tor Browser, it is likely that you already have them

Yep, I think we do have them also in the build machines because a few packages can be built without containers (esp. the signing tools).

And I think patch is installed by default on Debian, not sure why.

I'm not sure if it's installed by default. I would not expect it to be in the minimal chroot at least. On a new Debian install, when I see that make is not available I usually install the build-essential package which installs basic things like make and patch.

/cc @richard we will have to add this to the changelogs of 13.5a4 if we tag -build2.

Also, I'm not sure about whether we usually backport documentation to the maintenance branches. If we don't, we can close this already.

no backport for this is necessary