... | ... | @@ -1564,9 +1564,22 @@ The twin checks are present so that we can find stray Puppet hosts, |
|
|
for example if a host was retired from Nagios but not retired from
|
|
|
Puppet, or added to Nagios but not Puppet.
|
|
|
|
|
|
This was [implemented in March 2019](https://gitlab.torproject.org/tpo/tpa/team/-/issues/29676). An alternative implementation
|
|
|
[using Prometheus](https://forge.puppet.com/puppet/prometheus_reporter) was considered but [Prometheus still hasn't
|
|
|
replaced Nagios](https://gitlab.torproject.org/tpo/tpa/team/-/issues/29864) at the time of writing.
|
|
|
Note that we exclude some errors from the logs because we've been
|
|
|
having intermittent failures with PuppetDB since the Debian 10.12
|
|
|
"buster" point release on March 26 (see [issue
|
|
|
tpo/tpa/team#40699](https://gitlab.torproject.org/tpo/tpa/team/-/issues/40699)). We speculate this issue will go away when the
|
|
|
PuppetDB package is fixed ([tpo/tpa/team#40707](https://gitlab.torproject.org/tpo/tpa/team/-/issues/40707)).
|
|
|
|
|
|
The `check_puppetdb_nodes` was originally [deployed in March
|
|
|
2019](https://gitlab.torproject.org/tpo/tpa/team/-/issues/29676). An alternative check was the [check_puppet_agent](https://github.com/aswen/nagios-plugins/blob/master/check_puppet_agent) Nagios
|
|
|
check which has also recently (2022) been added to the
|
|
|
`tor-nagios.git` repository, but never actually used, as the puppetdb
|
|
|
check seems sufficient. It could, however, be used to replace the
|
|
|
above (to a certain extent) if we (for example) need to get rid of
|
|
|
PuppetDB for some reason.
|
|
|
|
|
|
An alternative implementation [using Prometheus](https://forge.puppet.com/puppet/prometheus_reporter) was considered but
|
|
|
[Prometheus still hasn't replaced Nagios](https://gitlab.torproject.org/tpo/tpa/team/-/issues/29864) at the time of writing.
|
|
|
|
|
|
There are no validation checks and *a priori* no peer review of code:
|
|
|
code is directly pushed to the Puppet server without validation. Work
|
... | ... | |