I'm working on the banner, and it's getting there, but it still needs some polishing. In the meantime, here are the strings (for review) we are going to use for the banner text. (This text was suggested by Shari, with minor revisions.) If these strings look OK, I would like to get these added to the repository ASAP so we can give the translators a chance to do the translation ahead of our deadline for the next release.
I'm working on the banner, and it's getting there, but it still needs some polishing. In the meantime, here are the strings (for review) we are going to use for the banner text. (This text was suggested by Shari, with minor revisions.) If these strings look OK, I would like to get these added to the repository ASAP so we can give the translators a chance to do the translation ahead of our deadline for the next release.
I'm working on the banner, and it's getting there, but it still needs some polishing. In the meantime, here are the strings (for review) we are going to use for the banner text. (This text was suggested by Shari, with minor revisions.) If these strings look OK, I would like to get these added to the repository ASAP so we can give the translators a chance to do the translation ahead of our deadline for the next release.
Here's the HTML/JS/CSS patch for review. For now it's only visible on US-English locales, but when we the strings have been translated, we can add another patch to show more locales.
Kathy and I reviewed the JS/HTML/CSS changes. They look okay; we noticed just a few small things:
The comment says "2016 Dec 1" for the start date but the code uses October 1st.
Please remove some of the console.log() statements.
"fitt" should be "fit" in one comment.
The CSS has some rules for other browsers, e.g., -khtml-user-select: none (but if the same CSS file is going to be used on the website, maybe you do not want to remove these).
It would be nice to clean up the extensions.torbutton.donation_banner2016.shown_count pref somehow. Maybe reset it after the end date has been reached? This is not a big deal though; I do not know if we cleaned up last year's pref.
Kathy and I reviewed the JS/HTML/CSS changes. They look okay; we noticed just a few small things:
Thanks for the review and catching all my mistakes!
The comment says "2016 Dec 1" for the start date but the code uses October 1st.
Fixed. The comment and code both now set a start date of November 15.
Please remove some of the console.log() statements.
Done.
"fitt" should be "fit" in one comment.
Fixed.
The CSS has some rules for other browsers, e.g., -khtml-user-select: none (but if the same CSS file is going to be used on the website, maybe you do not want to remove these).
Yes, I'll leave those in for that reason.
It would be nice to clean up the extensions.torbutton.donation_banner2016.shown_count pref somehow. Maybe reset it after the end date has been reached? This is not a big deal though; I do not know if we cleaned up last year's pref.