Remove the ClientAutoIPv6ORPort option

In #27490 (moved), we introduced the option ClientAutoIPv6ORPort, which randomly tries IPv4 or IPv6 randomly.

This option is not true Happy Eyeballs and fails very often, usually trying IPv6 on networks which are IPv4-only (#30639 (moved)).

We should remove this option.

changed milestone to %Tor: 0.4.4.x-final

Trac:
Parent Ticket: #29641 (moved)
Child Ticket(s): #32942 (moved), #30639 (moved)

added component::core tor/tor ipv6 milestone::Tor: 0.4.4.x-final owner::neel parent::29641 priority::medium resolution::fixed reviewer::dgoulet severity::normal status::closed type::enhancement labels

Trac:
Description: The ClientAutoIPv6ORPort fails very often, usually trying IPv6 on networks which are IPv4-only (#30639 (moved)). We should remove this option.

to

In #27490 (moved), we introduced the option ClientAutoIPv6ORPort, which randomly tries IPv4 or IPv6 randomly.

This option is not true Happy Eyeballs and fails very often, usually trying IPv6 on networks which are IPv4-only (#30639 (moved)).

We should remove this option.
Keywords: N/A deleted, ipv6 added
Version: N/A to Tor: unspecified
Milestone: N/A to Tor: unspecified

PR: https://github.com/torproject/tor/pull/1652

Also see: https://lists.torproject.org/pipermail/tor-dev/2020-January/014120.html

Trac:
Parent: N/A to #30639 (moved)

Trac:
Status: assigned to needs_review

Since this option has been present in tor for a few releases, we should deprecate it in one release, and then remove it in the next release,

Please open a separate ticket to deprecate the option in the deprecation table: https://gitweb.torproject.org/tor.git/tree/src/app/config/config.c#n819 We can merge that ticket into the current master.

Then, after we split off the next release, we can merge this ticket into master. (And revert the changes to the deprecation table.)

Trac:
Status: needs_review to needs_revision

I deprecated ClientAutoIPv6ORPort in ticket #32942 (moved) (commit 8d288eb3a7738e50a371db63d83ea37f4cfb67fb).

Setting as needs review for 0.4.4.x.

Trac:
Status: needs_revision to needs_review
Milestone: Tor: unspecified to Tor: 0.4.4.x-final

lgtm;

This is 0.4.4 and merge window hasn't opened yet.

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready

Trac:
Parent: #30639 (moved) to N/A

Trac:
Parent: N/A to #29641 (moved)

Trac:
Version: Tor: unspecified to N/A
Type: defect to enhancement

@neel, Hi! There is a merge conflict with latest git master because the tor.1.txt file has been re-ordered. You think you can rebase your branch on latest master?

If not, that is fine, I can take a shot and try to resolve the conflict. Thanks!

Trac:
Status: merge_ready to needs_revision

I couldn't merge the changes on the existing branch but I have moved the changes to a new PR: https://github.com/torproject/tor/pull/1751

Trac:
Status: needs_revision to needs_review

CI fails. The src/test/conf_examples/large_1/expected_no_dirauth file still has a reference to ClientAutoIPv6ORPort.

Else this lgtm.

Trac:
Status: needs_review to needs_revision

Should be good now.

Trac:
Status: needs_revision to needs_review

Thanks. Merged!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #29641 (moved)

mentioned in issue #30639 (moved)

mentioned in issue #32942 (moved)

moved to tpo/core/tor#32905 (closed)