Remove the ClientAutoIPv6ORPort option

changed milestone to %Tor: 0.4.4.x-final in legacy/trac

Trac:
Parent Ticket: legacy/trac#29641 (moved)
Child Ticket(s): legacy/trac#32942 (moved), legacy/trac#30639 (moved)

added component::core tor/tor in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.4.4.x-final in Legacy / Trac owner::neel in Legacy / Trac parent::29641 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::dgoulet in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels

Trac:
Description: The ClientAutoIPv6ORPort fails very often, usually trying IPv6 on networks which are IPv4-only (legacy/trac#30639 (moved)). We should remove this option.

to

In legacy/trac#27490 (moved), we introduced the option ClientAutoIPv6ORPort, which randomly tries IPv4 or IPv6 randomly.

This option is not true Happy Eyeballs and fails very often, usually trying IPv6 on networks which are IPv4-only (legacy/trac#30639 (moved)).

We should remove this option.
Keywords: N/A deleted, ipv6 added
Version: N/A to Tor: unspecified
Milestone: N/A to Tor: unspecified

PR: https://github.com/torproject/tor/pull/1652

Also see: https://lists.torproject.org/pipermail/tor-dev/2020-January/014120.html

Trac:
Parent: N/A to legacy/trac#30639 (moved)

Trac:
Status: assigned to needs_review

Since this option has been present in tor for a few releases, we should deprecate it in one release, and then remove it in the next release,

Please open a separate ticket to deprecate the option in the deprecation table: https://gitweb.torproject.org/tor.git/tree/src/app/config/config.c#n819 We can merge that ticket into the current master.

Then, after we split off the next release, we can merge this ticket into master. (And revert the changes to the deprecation table.)

Trac:
Status: needs_review to needs_revision

I deprecated ClientAutoIPv6ORPort in ticket legacy/trac#32942 (moved) (commit 8d288eb3).

Setting as needs review for 0.4.4.x.

Trac:
Status: needs_revision to needs_review
Milestone: Tor: unspecified to Tor: 0.4.4.x-final

lgtm;

This is 0.4.4 and merge window hasn't opened yet.

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready

Trac:
Parent: legacy/trac#30639 (moved) to N/A

Trac:
Parent: N/A to legacy/trac#29641 (moved)

Trac:
Version: Tor: unspecified to N/A
Type: defect to enhancement

@neel, Hi! There is a merge conflict with latest git master because the tor.1.txt file has been re-ordered. You think you can rebase your branch on latest master?

If not, that is fine, I can take a shot and try to resolve the conflict. Thanks!

Trac:
Status: merge_ready to needs_revision