(These ones cause parsing failures.)

Coccinelle doesn't understand the particular pattern of token
pasting we have going on here.

This will let us give specific in-file equivalents to given macros
or preprocessor directives, to make things parse.

Coccinelle doesn't understand it when we use "==" and "!=" and so on as
arguments to macros.  To solve this, we prefer OP_EQ, OP_NE, and so
on.

This commit is automatically generated by running
./scripts/coccinelle/test_operator_cleanup over all of the source
code in src.

Note that this header file behaves a bit strangely.  It is used by
coccinelle just for the purpose of knowing how to parse
difficult-to-parse stuff.  It doesn't need to produce good C -- just
grammatical C.

spatch can let us know whether a file has parsed "perfectly" or
not.  The more perfect it parses, the likelier any semantic patches
are to apply.  I've used this script to identify problem areas in
our code.

It's a bit tricky to remember the right incantation to get the
proper include paths and incantations for coccinelle, but without
it, coccinelle is less effective at parsing our C.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

See also ticket 31654.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Here we make it clear we're only looking at listable variable names,
not at whether the variables themselves are gettable.

Also, remove an extraneous h.

(This commit is not a fixup, because of rebase conflicts.)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

(This option tests our existing behavior, not necessarily the most
sensible behavior.)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

The old names remain as #defines that cause variables to get one or
more flags.

Now every flag-testing function in confparse.c tests exactly one flag.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Since the flags are now stored with compatible numbering, we can
just OR them together and see whether the flag we want is in the
result.

(Net code removal!)