juga authored 6 years ago and David Goulet committed 6 years ago

* remove the fixme since clearing the countries should be other issue
* remove unused variables related to it since that cause travis to fail

Isis Lovecruft authored 6 years ago and David Goulet committed 6 years ago

 * FIXES part of #25515: https://bugs.torproject.org/25515

juga authored 6 years ago and Isis Lovecruft committed 6 years ago

Signed-off-by: Isis Lovecruft <isis@torproject.org>

juga authored 6 years ago and Isis Lovecruft committed 6 years ago

Signed-off-by: Isis Lovecruft <isis@torproject.org>

This commit introduces the consensus parameter "circ_max_cell_queue_size"
which controls the maximum number of cells a circuit queue should have.

The default value is currently 50000 cells which is above what should be
expected but keeps us a margin of error for padding cells.

Related to this is #9072. Back in 0.2.4.14-alpha, we've removed that limit due
to a Guard discovery attack. Ticket #25226 details why we are putting back the
limit due to the memory pressure issue on relays.

Fixes #25226

Signed-off-by: David Goulet <dgoulet@torproject.org>

We removed this file, but didn't take it out of EXTRA_DIST -- thus
breaking "make dist".

"ours" to avoid version bump.

Both header and code file had some indentation issues after mass renaming.

No code behavior change.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Really, the uint32_t is only an optimization; any kind of unit
should work fine.  Some users might want to use time_t or
monotime_coarse_t or something like that.

(These functions were previously helper functions for
token_bucket_rw_t).

(The tests caught this one.)

Begin by creating a lowest-level triple of the types needed to
implement a token bucket: a configuration, a timestamp, and the raw
bucket itself.

Note that for low-level buckets, the units of the timestamp and the
bucket itself are unspecified: each user can use a different type.

(This patch breaks check-spaces; a later patch will fix it)

Signed-off-by: David Goulet <dgoulet@torproject.org>

Add to the Denial of Service section of the man page an explanation about the
three different mitigation Tor has.

Fixes #25248.

Signed-off-by: David Goulet <dgoulet@torproject.org>

(This function is no longer used.)

This is a simple search-and-replace to rename the token bucket type
to indicate that it contains both a read and a write bucket, bundled
with their configuration.  It's preliminary to refactoring the
bucket type.