- Jul 27, 2024
-
-
Kelsey Gilbert authored
There's no sufficiently robust way to identify POD types in C++, such that we could rely on this kind of thing for serialization. As one example, `bool` must be carefully handled on deserialize, in case an attacker wants to exploit the UB of bool with value 2. Additionally, generally it's not viable to tell whether all the members of a struct are PODs as well, and we need that level of assurance recursively! So we instead lean on e.g. ParamTraits_TiedFields/_IsEnumCase for our extreme robustness requirements. Differential Revision: https://phabricator.services.mozilla.com/D217518
-
- Jul 24, 2024
-
-
Kelsey Gilbert authored
Differential Revision: https://phabricator.services.mozilla.com/D217185
-
- Jun 20, 2024
-
-
Andreas Farre authored
Bug 1890748 - Move responsibility of FeaturePolicy initialization to nsILoadInfo. r=freddyb,necko-reviewers,jesup,dom-core,sefeng, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D207140
-
- Jun 07, 2024
-
-
Christian Holler (:decoder) authored
Differential Revision: https://phabricator.services.mozilla.com/D210326
-
- Jun 06, 2024
-
-
Gregory Pappas authored
It's not used since bug 1751047 Differential Revision: https://phabricator.services.mozilla.com/D212742
-
Jed Davis authored
Differential Revision: https://phabricator.services.mozilla.com/D212643
-
Jed Davis authored
Differential Revision: https://phabricator.services.mozilla.com/D212642
-
- Jun 05, 2024
-
-
Dana Keeler authored
Previously the PVerifySSLServerCert protocol consisted of two functions: one to call when certificate verification succeeded, and another to call upon failure. This was unnecessary, as the code before and after this protocol didn't have the same split. This patch unifies the protocol to better match the surrounding code. It also takes the opportunity to make use of some IPC helpers to serialize enums rather than manually casting to and from basic integer types. Differential Revision: https://phabricator.services.mozilla.com/D212594
-
- May 30, 2024
-
-
Otto Länd authored
# ignore-this-changeset
-
Ray Kraesig authored
* Adjust UtilityProcess{Host,Manager} to propagate ipc::LaunchErrors for their clients, or to create new ones where none previously existed. * Adjust the various clients of the above to to handle the additional information -- mostly by adding the additional failure-location data to log messages. * Fix an unrelated bug wherein the return type of `LaunchProcess` was declared as exclusive, despite being cached and reused. In particular, filedialog::Error objects should now contain -- and report to telemetry without further adjustment -- the actual error code from `ipc::LaunchError`s. (Reporting the original failure location as well will occur in bug 1884221.) Differential Revision: https://phabricator.services.mozilla.com/D209715
-
Ray Kraesig authored
Bug 1895375 - [1/4] Adjust types associated with ipc::LaunchError r=ipc-reviewers,win-reviewers,gstoll,nika As the intended use for LaunchError::mFunction is telemetry, avoid the possibility of accidental exfiltration of PII by requiring that LaunchError be constructed from `StaticString`. Additionally, remove the Windows-specific constructor overloads in favor of an explicit factory function, and explicitly document that `mError` is a generic bag of bits rather than any kind of strict error type. No functional changes. Differential Revision: https://phabricator.services.mozilla.com/D209712
-
- May 29, 2024
-
-
alwu authored
As we've added encryption scheme per content type in previous patches, there is no need to keep this old encryption scheme. Differential Revision: https://phabricator.services.mozilla.com/D211793
-
alwu authored
Bug 1898588 - part2 : remove duplicated method 'EncryptionSchemeStr'. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D211643
-
alwu authored
Bug 1898588 - part1 : add encryptionSchemes in MFCDMMediaCapability in order to support scheme per type r=jolin Currently our implementation is the scheme support per key system, not per content type. As each content type can have different supported scheme, eg. type A only supports cenc, but type B only supports cbcs, only having scheme per key system can't return a precise result. Differential Revision: https://phabricator.services.mozilla.com/D211642
-
- May 28, 2024
-
-
Narcis Beleuzu authored
Backed out changeset d23ba62a5165 (bug 1898588) Backed out changeset dd7a777b034f (bug 1898588) Backed out changeset 62c4a3361e00 (bug 1898588) Backed out changeset 2643cfcd1ba7 (bug 1898588) Backed out changeset 940fca861f93 (bug 1898588)
-
alwu authored
As we've added encryption scheme per content type in previous patches, there is no need to keep this old encryption scheme. Differential Revision: https://phabricator.services.mozilla.com/D211793
-
alwu authored
Bug 1898588 - part2 : remove duplicated method 'EncryptionSchemeStr'. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D211643
-
alwu authored
Bug 1898588 - part1 : add encryptionSchemes in MFCDMMediaCapability in order to support scheme per type r=jolin Currently our implementation is the scheme support per key system, not per content type. As each content type can have different supported scheme, eg. type A only supports cenc, but type B only supports cbcs, only having scheme per key system can't return a precise result. Differential Revision: https://phabricator.services.mozilla.com/D211642
-
- May 27, 2024
-
-
Cristian Tuns authored
Backed out changeset 9b708a1dc402 (bug 1890748) for causing bc failures in browser_permission_delegate_geo.js CLOSED TREE
-
Andreas Farre authored
Bug 1890748 - Move responsibility of FeaturePolicy initialization to nsILoadInfo. r=freddyb,necko-reviewers,jesup,dom-core,sefeng Differential Revision: https://phabricator.services.mozilla.com/D207140
-
- May 24, 2024
-
-
Butkovits Atila authored
-
Andreas Farre authored
Bug 1890748 - Move responsibility of FeaturePolicy initialization to nsILoadInfo. r=freddyb,necko-reviewers,jesup,dom-core,sefeng Differential Revision: https://phabricator.services.mozilla.com/D207140
-
- May 21, 2024
-
-
Gabriele Svelto authored
Differential Revision: https://phabricator.services.mozilla.com/D210309
-
- May 17, 2024
-
-
serge-sans-paille authored
Actually remove the check for demangle, no supported target need that check. Also make library dependencies explicit instead of relying on "$LIBS". Differential Revision: https://phabricator.services.mozilla.com/D203637
-
- May 15, 2024
-
-
Nika Layzell authored
This patch adjusts ManagedContainer to have a common base class, and exposes methods for interacting with this base class from generic code on IProtocol. This avoids the need for some specialized methods which were previously required in order to manipulate the managed lists which allows the ordering to be more precisely controlled in generic actor lifecycle methods. Differential Revision: https://phabricator.services.mozilla.com/D209855
-
Nika Layzell authored
This changes the way that StmtCode handles the pattern `$,{list}` alone on a line, adjusting it such that each item on the list is printed onto its own line, and then indented. This helps the formatting of large lists such as the ones generated in part 2. Differential Revision: https://phabricator.services.mozilla.com/D209854
-
Nika Layzell authored
Bug 1892652 - Part 2: Note if shmem allocation failed in message size too large crashes, r=ipc-reviewers,jld In part 1, a fallback was added to allow message buffers which would be sent as shmem to be sent inline if shmem allocation or mapping failed. This could potentially lead to an increase in message size too large crashes, as these messages are now being sent inline again. This patch adds an extra crash annotaion such that failures of this kind can be identified in socorro. Depends on D209880 Differential Revision: https://phabricator.services.mozilla.com/D209881
-
Nika Layzell authored
Bug 1892652 - Part 1: Fall back to sending buffer data inline if shmem allocation fails, r=ipc-reviewers,jld This may help reduce crashes in some cases, especially on 32-bit machines which may be suffering from severe memory fragmentation. This required serializing extra information for large buffers which would be sent as a shmem to record if the shmem allocation succeeded or failed on the sending side. Differential Revision: https://phabricator.services.mozilla.com/D209880
-
Tamas Szentpeteri authored
Backed out 3 changesets (bug 1883720, bug 1883719, bug 1883615) for causing multiple failures. CLOSED TREE Backed out changeset 495b9e84ba9d (bug 1883720) Backed out changeset 5a89cbc54dd2 (bug 1883615) Backed out changeset 9d075e352b0e (bug 1883719)
-
serge-sans-paille authored
Actually remove the check for demangle, no supported target need that check. Also make library dependencies explicit instead of relying on "$LIBS". Differential Revision: https://phabricator.services.mozilla.com/D203637
-
- May 14, 2024
-
-
Jamie Nicol authored
Bug 1880503 - Generate paired minidump when GPU process is killed following IPC timeout. r=aosmond,gsvelto When sync IPC under the top-level PCompositorManager protocol does not reply within a certain time threshold we purposefully kill the GPU process. While this allows the user to recover from a stuck GPU process, we have little visibility about the underlying cause. This patch makes it so that we generate a paired minidump for the GPU and parent processes prior to killing the GPU process in GPUProcessHost::KillHard(). The implementation roughly follows the equivalent for content processes in ContentParent::KillHard(). As the GPU process can be purposefully killed during normal operation, and because generating minidumps can be expensive, we are careful to only do so when the new argument aGenerateMinidump is true. We additionally remove the aReason argument as it is unused (and currently innacurate in some places). As these minidumps may not automatically submitted we limit the minidumps generation to twice per session in order to avoid accumulating a large number of unsubmitted minidumps on disk. Differential Revision: https://phabricator.services.mozilla.com/D202166
-
- May 13, 2024
-
-
Stanca Serban authored
Backed out changeset 437063345a7b (bug 1880503) Backed out changeset 9665aa5e821d (bug 1880503) Backed out changeset 44d08ce97ae6 (bug 1880503)
-
Jamie Nicol authored
Bug 1880503 - Generate paired minidump when GPU process is killed following IPC timeout. r=aosmond,gsvelto When sync IPC under the top-level PCompositorManager protocol does not reply within a certain time threshold we purposefully kill the GPU process. While this allows the user to recover from a stuck GPU process, we have little visibility about the underlying cause. This patch makes it so that we generate a paired minidump for the GPU and parent processes prior to killing the GPU process in GPUProcessHost::KillHard(). The implementation roughly follows the equivalent for content processes in ContentParent::KillHard(). As the GPU process can be purposefully killed during normal operation, and because generating minidumps can be expensive, we are careful to only do so when the new argument aGenerateMinidump is true. We additionally remove the aReason argument as it is unused (and currently innacurate in some places). As these minidumps may not automatically submitted we limit the minidumps generation to twice per session in order to avoid accumulating a large number of unsubmitted minidumps on disk. Differential Revision: https://phabricator.services.mozilla.com/D202166
-
Jon Coppeard authored
Bug 1895661 - Part 1: Move GC zeal functions to JS namespace and add separate constants for browser and shell frequency r=sfink Sensible defaults are very different for the browser and the shell so I added separate constants. I think the JS testing functions can get called from the browser and so may pick the wrong default but it's not too serious. Differential Revision: https://phabricator.services.mozilla.com/D210058
-
- May 08, 2024
-
-
Nika Layzell authored
In the changes from bug 1879375, the conditions for entries to be added to mPendingMessages was changed, such that it is now possible for the broker to temporarily have empty entries in this table. This means the assertion is no longer correct and should be removed. Differential Revision: https://phabricator.services.mozilla.com/D209861
-
- May 06, 2024
-
-
Sean authored
Bug 1860565 - Serialize and Deserialize LinkHeader::mAnchor in IPCMessageUtilsSpecializations.h r=manuel Differential Revision: https://phabricator.services.mozilla.com/D209454
-
- May 03, 2024
-
-
Nika Layzell authored
This is done by generating a new ID for the actor which can be successfully registered, then explicitly tearing the actor down, improving the consistency of error behaviour with other error cases during actor construction. Differential Revision: https://phabricator.services.mozilla.com/D209064
-
serge-sans-paille authored
Slightly restructure the script to be compatible with multiprocessing, but in a non-intrusive way: guard execution by __main__ and use shared containers for shared states. Avoid a redundant parser call (even if cached). Differential Revision: https://phabricator.services.mozilla.com/D207180
-
- May 02, 2024
-
-
Ryan VanderMeulen authored
Bug 1806946 - Skip GTests which fail when run under TSAN. r=profiler-reviewers,dom-storage-reviewers,tnikkel,xpcom-reviewers,ipc-reviewers,mccr8,janv,webrtc-reviewers,pehrsons,canaltinova Differential Revision: https://phabricator.services.mozilla.com/D209175
-
- Apr 30, 2024
-
-
Nika Layzell authored
Bug 1893087 - Part 2: Add test for constructing an actor under an already dead manager, r=ipc-reviewers,mccr8 Depends on D208936 Differential Revision: https://phabricator.services.mozilla.com/D209053
-