Opening MacOS dmg file is causing a warning, since 13.0

OS: MacOS Problem: Two users reported they downloaded TB for MacOS from @gettor_bot on Telegram and got an error message (The application cannot be open) while trying to install it. When they downloaded TB from our website (to be precise - from the mirror) - the installation competed without errors.

assigned to @meskio

added Doing label

I downloaded the macos installer both from the torproject.org website and from telegram and I get the same file:

❯ sha256sum tor-browser-macos-13.0.1.dmg
3000b97ab595d6ce3cfd7554079c14c7fe41e5c3aef791c65c6a94aeafe526f4  tor-browser-macos-13.0.1.dmg

Can it be that the mirror has an older version and 13.0.1 is broken? I've tried to install the telegram .dmg in a OSX and it failed.

@boklm @pierov do you know if there is a problem with 13.0.1 in macosx?

I downloaded the macos installer both from the torproject.org website and from telegram and I get the same file:

❯ sha256sum tor-browser-macos-13.0.1.dmg
3000b97ab595d6ce3cfd7554079c14c7fe41e5c3aef791c65c6a94aeafe526f4  tor-browser-macos-13.0.1.dmg

Can it be that the mirror has an older version and 13.0.1 is broken?

The sha256sum looks correct.

I've tried to install the telegram .dmg in a OSX and it failed.

Do you have more details about how it failed?

@boklm @pierov do you know if there is a problem with 13.0.1 in macosx?

We recently changed how we are signing for macos (#29815 (closed)). I'm wondering if the issue you have could be related to that. But I didn't see other people reporting any issue about that.

I've tried to install the telegram .dmg in a OSX and it failed.

I had a warning when opening the dmg, but apart from that everything worked.

I tried on an old version on x86_64. We can ask Claire or Dan to test in aarch64 later.

Do you have more details about how it failed?

I think is the same warning @pierov mentions:

I didn't notice before that you can actually continue. Is this error new from a recent TB image? And that be the explanation why the mirror worked for them?

BTW, I'm also using x86_64.

Yes, this is the warning, but I don't remember if we've always had it.

It might be a consequence of the new signing method.

Do you also have the same warning with 13.0, or is that something new with 13.0.1?

https://archive.torproject.org/tor-package-archive/torbrowser/13.0/tor-browser-macos-13.0.dmg

Yes, I do (sorry, the system is in Italian to catch any bugs with l10n):

12.5.2 seems okay. and so is 12.5.6, the final 12.5.x.

Maybe something has happened in the ESR upgrade.

Currently we sign the content of the dmg, but not the dmg itself. I'm wondering if this is what is causing the warning (although we didn't sign the dmg in previous versions either, so that's not something new).

It seems there is a "Disk Utility" that can verify the dmg file, and maybe give more details: https://support.apple.com/guide/disk-utility/verify-a-disk-images-data-corrupted-utility-dskutl15186/mac

It seems to be a checksum.

We changed naming scheme in the meantime but I don't think it's the issue.

Screenshot

12.5.2 seems okay.

Maybe something has happened in the ESR upgrade.

Or maybe that's related to the changes from #40847 (closed) (2579da7c).

That should only influence the size of the hfs volume we create (we have to do some guesswork for an initial rough size ).

There's a SOS button. With 12.5.x it tells the filesystem is okay, with 13.0 I get error -69845

That should only influence the size of the hfs volume we create (we have to do some guesswork for an initial rough size ).

Ah, and I see now we already had this change in 12.5.

More info about the error

LANG=en-US fsck_hfs -fy -x /dev/rdisk3

<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>INFORMATION</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>118</integer>
		<key>fsck_msg_string</key> <string>Executing %1$@ (version %2$@).</string>
		<key>parameters</key>
		<array>
			<string>fsck_hfs</string>
			<string>hfs-522.100.5</string>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>217</integer>
		<key>fsck_msg_string</key> <string>Checking non-journaled HFS Plus Volume.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>INFORMATION</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>121</integer>
		<key>fsck_msg_string</key> <string>The volume name is %1$@</string>
		<key>parameters</key>
		<array>
			<dict><key>volumename</key> <string>Tor Browser</string></dict>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>201</integer>
		<key>fsck_msg_string</key> <string>Checking extents overflow file.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>ERROR</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>608</integer>
		<key>fsck_msg_string</key> <string>Unused node is not erased (node = %1$@)</string>
		<key>parameters</key>
		<array>
			<integer>105</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>0</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>202</integer>
		<key>fsck_msg_string</key> <string>Checking catalog file.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>1</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>ERROR</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>608</integer>
		<key>fsck_msg_string</key> <string>Unused node is not erased (node = %1$@)</string>
		<key>parameters</key>
		<array>
			<integer>105</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>207</integer>
		<key>fsck_msg_string</key> <string>Checking multi-linked files.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>16</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>203</integer>
		<key>fsck_msg_string</key> <string>Checking catalog hierarchy.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>22</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>23</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>24</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>27</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>28</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>29</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>204</integer>
		<key>fsck_msg_string</key> <string>Checking extended attributes file.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>ERROR</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>608</integer>
		<key>fsck_msg_string</key> <string>Unused node is not erased (node = %1$@)</string>
		<key>parameters</key>
		<array>
			<integer>20</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>205</integer>
		<key>fsck_msg_string</key> <string>Checking volume bitmap.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>206</integer>
		<key>fsck_msg_string</key> <string>Checking volume information.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>33</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>FAIL</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>109</integer>
		<key>fsck_msg_string</key> <string>The volume %1$@ was found corrupt and needs to be repaired.</string>
		<key>parameters</key>
		<array>
			<dict><key>volumename</key> <string>Tor Browser</string></dict>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>100</integer>
		</array>
	</dict>
</plist>

Do you also see the same warning with the unsigned dmg from https://tb-build-02.torproject.org/~richard/builds/torbrowser/release/unsigned/13.0.1/ ?

Yep, same problem.

Click to expand

<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>INFORMATION</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>118</integer>
		<key>fsck_msg_string</key> <string>Executing %1$@ (version %2$@).</string>
		<key>parameters</key>
		<array>
			<string>fsck_hfs</string>
			<string>hfs-522.100.5</string>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>217</integer>
		<key>fsck_msg_string</key> <string>Checking non-journaled HFS Plus Volume.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>INFORMATION</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>121</integer>
		<key>fsck_msg_string</key> <string>The volume name is %1$@</string>
		<key>parameters</key>
		<array>
			<dict><key>volumename</key> <string>Tor Browser</string></dict>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>201</integer>
		<key>fsck_msg_string</key> <string>Checking extents overflow file.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>ERROR</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>608</integer>
		<key>fsck_msg_string</key> <string>Unused node is not erased (node = %1$@)</string>
		<key>parameters</key>
		<array>
			<integer>100</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>0</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>202</integer>
		<key>fsck_msg_string</key> <string>Checking catalog file.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>1</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>ERROR</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>608</integer>
		<key>fsck_msg_string</key> <string>Unused node is not erased (node = %1$@)</string>
		<key>parameters</key>
		<array>
			<integer>100</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>207</integer>
		<key>fsck_msg_string</key> <string>Checking multi-linked files.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>16</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>203</integer>
		<key>fsck_msg_string</key> <string>Checking catalog hierarchy.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>17</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>18</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>21</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>28</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>29</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>204</integer>
		<key>fsck_msg_string</key> <string>Checking extended attributes file.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>ERROR</string>
		<key>fsck_verbosity</key> <integer>1</integer>
		<key>fsck_msg_number</key> <integer>608</integer>
		<key>fsck_msg_string</key> <string>Unused node is not erased (node = %1$@)</string>
		<key>parameters</key>
		<array>
			<integer>18</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>205</integer>
		<key>fsck_msg_string</key> <string>Checking volume bitmap.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>VERIFY</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>206</integer>
		<key>fsck_msg_string</key> <string>Checking volume information.</string>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>33</integer>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>FAIL</string>
		<key>fsck_verbosity</key> <integer>0</integer>
		<key>fsck_msg_number</key> <integer>109</integer>
		<key>fsck_msg_string</key> <string>The volume %1$@ was found corrupt and needs to be repaired.</string>
		<key>parameters</key>
		<array>
			<dict><key>volumename</key> <string>Tor Browser</string></dict>
		</array>
	</dict>
</plist>
<plist version="1.0">
	<dict>
		<key>fsck_msg_type</key> <string>PROGRESS</string>
		<key>parameters</key>
		<array>
			<integer>100</integer>
		</array>
	</dict>
</plist>

@boklm you can extract the hfs with libdmg-hfsplus:

libdmg-hfsplus/dmg iso ~/Tor/tor-browser-build/torbrowser/alpha/unsigned/13.5a1/tor-browser-macos-13.5a1.dmg volume.hfs

At that point it can be analyzed also on Linux.

fsck.hfsplus is giving me similar errors, but I'd prefer to find a way to know what nodes the problematic ones are.

Possible ideas:

• try to partially populate the HFS volume, to see when it starts breaking
• run a git bisect on the hfs tool (IIRC, we've updated it when Moz accepted our PR for reproducibility)

you can extract the hfs with libdmg-hfsplus:

libdmg-hfsplus/dmg iso ~/Tor/tor-browser-build/torbrowser/alpha/unsigned/13.5a1/tor-browser-macos-13.5a1.dmg volume.hfs

At that point it can be analyzed also on Linux.

fsck.hfsplus is giving me similar errors, but I'd prefer to find a way to know what nodes the problematic ones are.

Interesting: the HFS before being compressed into a .dmg is fine. Extracting a dmg with that command line doesn't return the same dmg, but returns a corrupted one.

Extracting the unsigned 12.5 returns an okay HFS filesystem. Recompressing the 12.5 HFS obtained in this way with the old version of the dmg utility, and then extracting it again, returns the same FS.

Recompressing the 12.5 HFS with the new version of dmg and extracting it again, returns a bad HFS:

fsck logs

** 12.5-extr.hfs
	Using cacheBlockSize=32K cacheTotalBlock=1024 cacheSize=32768K.
   Executing fsck_hfs (version 540.1-Linux).
	Block 823934 is not an MDB or Volume Header 
** Checking non-journaled HFS Plus Volume.
   The volume name is Tor Browser
** Checking extents overflow file.
** Checking catalog file.
** Checking multi-linked files.
** Checking catalog hierarchy.
** Checking extended attributes file.
** Checking volume bitmap.
** Checking volume information.
   Volume header needs minor repair
	invalid alternate VHB at 823934 result -60 
   Verify Status: VIStat = 0x8000, ABTStat = 0x0000 EBTStat = 0x0000
                  CBTStat = 0x0000 CatStat = 0x00000000
** Repairing volume.
** Rechecking volume.
** Checking non-journaled HFS Plus Volume.
   The volume name is Tor Browser
** Checking extents overflow file.
** Checking catalog file.
** Checking multi-linked files.
** Checking catalog hierarchy.
** Checking extended attributes file.
** Checking volume bitmap.
** Checking volume information.
** The volume Tor Browser was repaired successfully.

So, I think I have to bisect the utility .

2ee327795680 (presumably 2ee327795680101d36f9700bd0fb618362237718) --> good

2cb30de5b277 (presumably 2cb30de5b277bf2bc1fc129899bb9382bb56ccca, my uplift) --> bad

Time to do some bisect, but it's just 8 commits.

Okay, instead of bisecting, I've taught: I already have !847 (merged).

I hadn't build it on my machine, so I've just done it and it seems to solve the issue.

Do you want to move this issue to the applications team? or to open a new one? I don't think I have permissions but I just added both of you into this repo so you can move it if you want.

unassigned @meskio

removed Doing label

moved from tpo/anti-censorship/gettor-project/OnionSproutsBot#57 (moved)

changed title from TB for MacOS obtained from the gettor_bot (Telegram) did not work to Opening MacOS dmg file is causing a warning, since 13.0

added Bug Doing MacOS labels

assigned to @pierov

removed Doing label

added Next label

added Doing label and removed Next label

mentioned in merge request !847 (merged)

marked this issue as related to #40986 (closed)

marked this issue as related to #40998 (closed)

marked this issue as related to #41014 (closed)

marked this issue as related to #40985 (closed)

marked this issue as related to #40987 (closed)

removed Doing label

added Backport label

added Needs Review label

removed Needs Review label

removed Backport label

added Build System label

closed

mentioned in merge request !852 (merged)

reopened

I'm afraid that happened again. The user complained TB for MacOS they obtained from the bot did not work. The one they got from the Calyx mirror worked fine.

I tested myself, and yes, TB for MacOS from the bot after I installed it and opened gave me this error!

The one I've got from torproject.org worked fine.

This looks like a different problem than the one we had before (the other one was a warning, this one if I understand correctly doesn't allow you to continue).

In case, could we move to a new issue for 13.0.11?

Also, could you please add some information like the macOS version and architecture?

I tried on an old macOS 10.15 on x86 and it worked, and it wouldn't be surprising if this was an ARM problem only.

I tested on 14.3.1 (Sonoma) M1 Mac

Okay, thanks for the information!

Since this is a different problem than the original one, I opened #41103 to continue with the new one.

@meskio is this on anti-censorship, given that the officially published dmgs are working? What is the bot giving people?

The telegram bot is handing out TB 13.0.11:

809fd7b1c5859cd9a4abebdb20a6b99e51b3c46d865f030b88fe5d6590bcbfdd  tor-browser-macos-13.0.11.dmg

Seems to be the same I downloaded from torproject.org:

809fd7b1c5859cd9a4abebdb20a6b99e51b3c46d865f030b88fe5d6590bcbfdd  tor-browser-macos-13.0.11.dmg

I have tried the calyx mirror and I get the same SHA256 hash.

Is weird if one of them works and not the other. Maybe a download failure?

@nina can you compare the hashes and file sizes? I'm also leaning toward download failure here.

file sizes are exactly the same, 210,994,572 bytes I also checked the digital signature for the one I got from the bot - "Good signature"

Is weird if one of them works and not the other. Maybe a download failure?

I was able to install both TB, I got the error message when I tried to open already installed "telegram" one

mentioned in issue #41103

closed