Skip to content
Snippets Groups Projects

Bug 40305 v2+macos

Closed Matthew Finkel requested to merge sysrqb/tor-browser-build:bug_40305_v2+macos into master
All threads resolved!

Closes #40307 (closed)

This is a WIP branch. It builds but I don't know if it crashes. The single commit could be divided into smaller pieces.

Merge request reports

Approval is optional

Closed by boklmboklm 3 years ago (Oct 7, 2021 4:36pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • One thing I forgot to mention is that Mozilla is not using MacOSX11.0.SDK for their x86_64 builds - they are still building against 10.12. They have https://bugzilla.mozilla.org/show_bug.cgi?id=1696504 for moving x86_64 to 11.0. I'm concerned about this deviation from Mozilla, but I'm not concerned enough to find a 10.12 SDK right now. @duncan reported that the macOS builds are not crashing, so this is not a high priority for me right now.

  • One thing I forgot to mention is that Mozilla is not using MacOSX11.0.SDK for their x86_64 builds - they are still building against 10.12. They have https://bugzilla.mozilla.org/show_bug.cgi?id=1696504 for moving x86_64 to 11.0. I'm concerned about this deviation from Mozilla, but I'm not concerned enough to find a 10.12 SDK right now.

    Hrm. That's indeed a bit concerning. We had #40034 (closed) which @mcs and @brade fixed like ages ago, assembling the SDK for us. But it seems it's not there anymore. Not sure where it went, though. :) It seems I don't have a local copy of it either...

    I guess we should at least make sure the macOS bundles we produce work on all supported macOS versions. And then hope for the best.

  • Georg Koppen resolved all threads

    resolved all threads

  • I included those changes in !346 (closed), in 65a4b893. With the following changes:

    • we are not using our build of python for clang and rust, but use the python3 package from bullseye. Although we are still building python3 for building firefox, but maybe we can remove that one too.
    • we are not building binutils for building clang, but use the one from bullseye.
  • boklm resolved all threads

    resolved all threads

  • boklm mentioned in commit 5c4ec887

    mentioned in commit 5c4ec887

  • closed

  • Please register or sign in to reply
    Loading