Bug 40742: Add Privacy Browser targets

Merge Info

Related Issues

• #40742 (closed)
• #40745 (closed)
• #40753 (closed)

Backport Timeline

• Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
• Next Minor Stable Release - patchset that needs to be verified in nightly before backport
• Eventually - patchset that needs to be verified in alpha before backport
• No Backport - patchset for the next major stable

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Change Description

This MR should allow us to build Privacy Browser build.

It introduces the following changes:

1. it allows us to customize MOZ_APP_BASENAME, which has direct effects on the output paths and filenames
2. it adds a few needed files for the Windows and macOS installers
3. it adds the privacybrowser targets
4. it adds the torbrowser- prefix to the Makefile targets for generating updates
5. it adds privacybrowser to the .gitignore (and adds back release, alpha and nightly to guarantee compatibility with older builds and with maint-12.0)
6. it updates the needed documentation

So far, the builds work, but only if you use the single target. Group targets (such as desktop) don't work, but I cannot fix them on my own.

assigned to @pierov

requested review from @boklm

added 8 commits

• e0030e99...7855f0b6 - 6 commits from branch tpo/applications:main
• 9ecaa3cc - Bug 40742: Create placeholder files for Privacy Browser installers
• 431e0e68 - Bug 40742: Add Privacy Browser targets

Compare with previous version

Rebased to main not to include other MRs' commits anymore.

added 1 commit

• f75185d9 - fixup! Bug 40742: Add Privacy Browser targets

Compare with previous version

added 1 commit

• efe1275d - fixup! Bug 40742: Create placeholder files for Privacy Browser installers

Compare with previous version

added 2 commits

• 816c9e16 - fixup! Bug 40742: Add Privacy Browser targets
• 81bca937 - Bug 40745: Allow customizing MOZ_APP_BASENAME

Compare with previous version

changed the description

added 2 commits

• a2b8da40 - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME
• bc39f3f4 - fixup! Bug 40742: Add Privacy Browser targets

Compare with previous version

added 2 commits

• 1d6a93b4 - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME
• 1d4b67d3 - fixup! Bug 40742: Create placeholder files for Privacy Browser installers

Compare with previous version

added 14 commits

• 1d4b67d3...d940f9db - 4 commits from branch tpo/applications:main
• 98a41406 - Bug 40742: Create placeholder files for Privacy Browser installers
• 7d0db9a1 - Bug 40742: Add Privacy Browser targets
• fae71ced - fixup! Bug 40742: Add Privacy Browser targets
• d1273427 - fixup! Bug 40742: Create placeholder files for Privacy Browser installers
• 967c1383 - fixup! Bug 40742: Add Privacy Browser targets
• 7bce28db - Bug 40745: Allow customizing MOZ_APP_BASENAME
• a493a7ca - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME
• 9e4a6087 - fixup! Bug 40742: Add Privacy Browser targets
• 316ffa36 - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME
• 0129cf0f - fixup! Bug 40742: Create placeholder files for Privacy Browser installers

Compare with previous version

added 1 commit

• 519a596d - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME

Compare with previous version

added 1 commit

• 299b79c6 - fixup! Bug 40742: Add Privacy Browser targets

Compare with previous version

There are many fixup!s, because I've used tb-build-05 to build and the branch to sync.

However, I think that I could squash them already, and then start with a final review when I mark this as ready.

added 2 commits

• 3daf58e8 - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME
• 7ff4c001 - fixup! Bug 40742: Add Privacy Browser targets

Compare with previous version

mentioned in issue #40749 (closed)

added 1 commit

• fbe072d7 - fixup! Bug 40745: Allow customizing MOZ_APP_BASENAME

Compare with previous version