Skip to content
Snippets Groups Projects

Bug 40852 Reproducible build of lox library and js bindings

Merged Cecylia Bocovich requested to merge cohosh/tor-browser-build:lox-wasm into main

Merge Info

  • Related Issues

  • Backport Timeline

    • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
    • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
    • Eventually - patchset that needs to be verified in alpha before backport
    • No Backport - patchset for the next major stable
  • Issue Tracking

Change Description

Edited by boklm

Merge request reports

Approved by

Merged by boklmboklm 1 year ago (Oct 17, 2023 1:42pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • morgan
  • @boklm can you also review please?

  • Maintainer

    I think we can add a cargo_vendor-lox makefile target.

    Otherwise lgtm.

    • Author Contributor
      Resolved by morgan

      Hey sorry this is a WIP and not ready for review. I just opened it so it's tracked. Do you want me to close and reopen later when it's ready?

  • morgan marked this merge request as draft

    marked this merge request as draft

  • Cecylia Bocovich added 29 commits

    added 29 commits

    • 0ccce0d3...f4227713 - 15 commits from branch tpo/applications:main
    • f4227713...564b51d2 - 4 earlier commits
    • 8006383a - Bug 40802: Update the wasi-sdk and remove the patch to make it reproducible.
    • 42b0f1e3 - Bug 31588: Create cargo vendor archives locally
    • 2cbdb5df - Bug 40855: Update toolchains for Firefox 115 (common part)
    • 9716c8f8 - Bug 40855: Update toolchains for Firefox 115 (Windows part)
    • 77b8ef03 - Bug 40855: Update toolchains for Firefox 115 (macOS part)
    • ba6f9137 - Bug 40855: Update toolchains for Firefox 115 (Android part)
    • 52af2d40 - NOT FOR MERGE: Use custom Firefox trees
    • 398c3a72 - Bug 40852: Compile lox library to wasm
    • 4645efd1 - Bug 40852: Add wasm-bindgen project
    • b79def7c - Bug 40852: Generate javascript bindings for lox-wasm

    Compare with previous version

  • Cecylia Bocovich added 67 commits

    added 67 commits

    • b79def7c...d41f0f7b - 64 commits from branch tpo/applications:main
    • 2c463046 - Bug 40852: Compile lox library to wasm
    • 5f24e3df - Bug 40852: Add wasm-bindgen project
    • 2126aebb - Bug 40852: Generate javascript bindings for lox-wasm

    Compare with previous version

  • Cecylia Bocovich added 3 commits

    added 3 commits

    • feb04c7b - Bug 40852: Compile lox library to wasm
    • 88f9331e - Bug 40852: Add wasm-bindgen project
    • 351d4319 - Bug 40852: Generate javascript bindings for lox-wasm

    Compare with previous version

  • Author Contributor

    This has now been rebased and I redid some of the vendoring work to match the current best practices of other rust projects. I think it's ready for a review.

  • Cecylia Bocovich marked this merge request as ready

    marked this merge request as ready

  • Cecylia Bocovich changed title from Draft: WIP: Bug 40852 Reproducible build of lox library and js bindings to Bug 40852 Reproducible build of lox library and js bindings

    changed title from Draft: WIP: Bug 40852 Reproducible build of lox library and js bindings to Bug 40852 Reproducible build of lox library and js bindings

  • assigned to @cohosh

  • morgan requested review from @boklm and removed review request for @richard

    requested review from @boklm and removed review request for @richard

    • Resolved by boklm

      @boklm I'm not terribly familiar with how cargo vendoring works, can you have a final review now that its been rebased?

  • morgan resolved all threads

    resolved all threads

  • boklm approved this merge request

    approved this merge request

  • boklm added 58 commits

    added 58 commits

    • 351d4319...5380e131 - 55 commits from branch tpo/applications:main
    • 3b1b0d89 - Bug 40852: Compile lox library to wasm
    • f1003d94 - Bug 40852: Add wasm-bindgen project
    • 94a3fda8 - Bug 40852: Generate javascript bindings for lox-wasm

    Compare with previous version

  • boklm marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

    marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading