FF98 Audit

General

The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).

The output includes the entire patch where the new problematic code was introduced. Search for XXX MATCH XXX to find the next potential violation.

code_audit.sh contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.

Firefox: https://github.com/mozilla/gecko-dev.git

  • Start: 82764d45153d175f4686ead7aac977810fe1fd1b ( FIREFOX_RELEASE_98_BASE )
  • End: 99300ebd4a4a6440b6a11a80108f1ed6d867cdb4 ( FIREFOX_RELEASE_99_BASE )

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)


Application Services: https://github.com/mozilla/application-services.git

  • Start: 17942945873cdb8be56a9316d3cb8a611b3ef321 ( v91.1.0 )
  • End: 1fcdb5984be6e0cc460d00cde44c49b7e3ac1ec6 ( v92.0.0 )

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)

Android Components: https://github.com/mozilla-mobile/android-components.git

  • Start: 6f6ed0ca80410e42e8781bcf856e686ecbff2f63 ( v98.0.0 )
  • End: a31f2c481a7e220ca87affd8cd88fcb42b1624c1 ( v98.0.13 )

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)

Fenix: https://github.com/mozilla-mobile/fenix.git

  • Start: 6c290430adc9af36e5123a78360a602bb5509c6c ( v98.0.0-beta.1 )
  • End: 0df2c648ab38682569e823b2140b945a0d7d6a9b ( releases_v98.0.0 )

Languages:

  • java
  • cpp
  • js
  • rust

Nothing of interest (using code_audit.sh)

Ticket Review

98 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=98%20Branch&order=priority%2Cbug_severity&limit=0

  • https://bugzilla.mozilla.org/show_bug.cgi?id=1749501 : @ma1 tor-browser#41134 (closed)
  • https://bugzilla.mozilla.org/show_bug.cgi?id=1749323 : @dan tor-browser#41135 (closed)
  • https://bugzilla.mozilla.org/show_bug.cgi?id=1749635 : @pierov tor-browser#41136 (closed)
  • https://bugzilla.mozilla.org/show_bug.cgi?id=1751170 : @pierov tor-browser#41137 (closed)

Nothing of interest (manual inspection)

OR (foreach)**

foreach PROBLEMATIC_TICKET:

$(PROBLEMATIC_TICKET)

  • Summary
  • Review Result: (SAFE|BAD)

Regression/Prior Vuln Review

Review proxy bypass bugs; check for new vectors to look for:

  • https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
    • Look for new features like these. Especially external app launch vectors

Export

  • Export Report and save to tor-browser-spec/audits
Edited Aug 23, 2022 by morgan
Assignee Loading
Time tracking Loading