Consider adding MOZ_SERVICES_HEALTHREPORT to mozconfig

Someone suggested on the blog that we unset MOZ_SERVICES_HEALTHREPORT in mozconfig: https://blog.torproject.org/comment/285469#comment-285469

Apparently unsetting this would avoid including the file toolkit/components/telemetry/healthreport-prefs.js, which currently contains:

pref("datareporting.healthreport.infoURL", "https://www.mozilla.org/legal/privacy/firefox.html#health-report");
pref("datareporting.healthreport.uploadEnabled", true);

We already set datareporting.healthreport.uploadEnabled to false, so this wouldn't fix any issue, but would be defense in depth.

added TorBrowserTeam202002R in Legacy / Trac component::applications/tor browser in Legacy / Trac owner::tbb-team in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-9.5a6 in Legacy / Trac tbb-backport in Legacy / Trac tbb-no-uplift in Legacy / Trac tbb-rbm in Legacy / Trac type::task in Legacy / Trac labels

Moving tickets to December

Trac:
Keywords: TorBrowserTeam201911 deleted, TorBrowserTeam201912 added

ticket:31457#comment:9 The same is needed here:

-imply_option('MOZ_SERVICES_HEALTHREPORT', True)
+imply_option('MOZ_SERVICES_HEALTHREPORT', False)

https://searchfox.org/mozilla-esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#3116

Trac:
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam202001 added

Replying to cypherpunks:

https://searchfox.org/mozilla-esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#3116

So it seems disabling MOZ_SERVICES_HEALTHREPORT might allow us to disable MOZ_DATA_REPORTING too?

Trac:
0001-Bug-32493-Disable-MOZ_SERVICES_HEALTHREPORT.patch

I attached a patch to disable MOZ_SERVICES_HEALTHREPORT.

Trac:
Keywords: TorBrowserTeam202001 deleted, TorBrowserTeam202001R added
Status: new to needs_review

Moving reviews to February

Trac:
Keywords: TorBrowserTeam202001R deleted, TorBrowserTeam202002R added

Replying to boklm:

Replying to cypherpunks:

https://searchfox.org/mozilla-esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#3116

So it seems disabling MOZ_SERVICES_HEALTHREPORT might allow us to disable MOZ_DATA_REPORTING too? Yes. LGTM.

Thanks! I'd like this patch as a squash! on TB4: Tor Browser's Firefox preference overrides. (currently 4348eef9818fdbda51b9a89aa1cacc71c9770052). Can you update the patch or do you want me to update it?

Trac:
Status: needs_review to needs_revision

Replying to sysrqb:

Thanks! I'd like this patch as a squash! on TB4: Tor Browser's Firefox preference overrides. (currently 4348eef9818fdbda51b9a89aa1cacc71c9770052). Can you update the patch or do you want me to update it?

Sorry, ingore that. This patch is good as-is. I applied as commit 6046d1d582804594a57d132280376b8027d1ed83 on tor-browser-68.5.0esr-9.5-1.

We already have a similar patch for Android.

Trac:
Keywords: N/A deleted, tbb-9.5a6 added
Resolution: N/A to fixed
Status: needs_revision to closed

Trac:
Keywords: N/A deleted, tbb-backport added

Trac:
Keywords: N/A deleted, tbb-no-uplift added

closed

mentioned in issue legacy/trac#32700 (moved)

mentioned in issue legacy/trac#34055 (moved)

moved from legacy/trac#32493 (moved)

added Task label and removed 1 deleted label

removed 1 deleted label

removed 1 deleted label