Review Mozilla 1765167c: Deprecate Cu.import

https://bugzilla.mozilla.org/show_bug.cgi?id=1765167

I suspect you've already discovered this, but fyi for the tor-laucher and torbutton migration/refactors

cc @ma1

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

added New Identity Next Sponsor 131 Q3 Security Settings labels

assigned to @pierov

mentioned in issue tor-browser-spec#40037 (closed)

marked this issue as related to tor-browser-spec#40037 (closed)

This is an error the linter can find.

So, I've already fixed them for #40012 (closed) in tor-browser.git (actually, I don't think we had any, IIRC).

tor-launcher and torbutton have them. I have linted tor-launcher for #40933 (closed), and the "destructing" changes are not committed yet (but about:tor doesn't work anymore).

So, we could review the linting, and merge it anyway to main of tor-launcher.

But, tbh, I think that we should ignore them, and proceed with the migration instead, without fixing this bug in tor-launcher.git.

I'm not sure for torbutton.

marked this issue as related to #40012 (closed)

marked this issue as related to #40933 (closed)

torbutton linting: torbutton!91 (merged). It didn't have any Cu.import (it has a Cu.importGlobalProperties(["crypto"]);, which is different).

added Doing label and removed Next label

tor-launcher (main)>  grep -r Cu\\.import
src/chrome/content/network-settings.js:Cu.import("resource://gre/modules/Services.jsm");
src/chrome/content/network-settings.js:Cu.import("resource://gre/modules/XPCOMUtils.jsm");
src/chrome/content/network-settings.js:  let { AddonManager } = Cu.import("resource://gre/modules/AddonManager.jsm");
src/components/tl-process.js:try { Cu.import("resource://gre/modules/ctypes.jsm"); } catch(e) {}
src/components/tl-process.js:Cu.import("resource://gre/modules/XPCOMUtils.jsm");
src/components/tl-protocol.js:Cu.import("resource://gre/modules/XPCOMUtils.jsm");
src/components/tl-protocol.js:Cu.import("resource://gre/modules/Services.jsm");
src/components/tl-protocol.js:let { configureControlPortModule, controller } = Cu.import("resource://torbutton/modules/tor-control-port.js", {});
src/components/tl-protocol.js:// Cu.import("resource://gre/modules/XPCOMUtils.jsm");
src/modules/tl-bridgedb.jsm:Cu.import("resource://gre/modules/Services.jsm");
src/modules/tl-bridgedb.jsm:Cu.import("resource://gre/modules/Subprocess.jsm");
src/modules/tl-bridgedb.jsm:Cu.import("resource://gre/modules/XPCOMUtils.jsm");
src/modules/tl-logger.jsm:Cu.import("resource://gre/modules/XPCOMUtils.jsm");
src/modules/tl-util.jsm:Cu.import("resource://gre/modules/XPCOMUtils.jsm");

I have already linted tl-protocol.js, tl-process and tl-util.jsm. Do we want to merge my changes, and finish linting the remaining ones, @richard?

Or since we are probably getting rid of tor-launcher with 102, should we keep them like they currently are?

As an alternative, we could also lint main, without using my currently linted commits.

Let's just leave them as is for now and just update in tor-browser

removed Q3 label

added Q4 label

Done with !348 (merged) and with torbutton!91 (merged).

closed

marked this issue as related to tor-browser-build#40627 (closed)

removed Doing label