Audit each of our UX components for accessibilty issues

As discussed in our on-boarding, we have various new UX components added to Tor Browser. Accessibility concerns have historically not been a high priority. We should go through each of our components and ensure (at least on a technical level) that the proper annotations/etc are set in the XUL/HTML.

The list of features and their commit hashes in the tor-browser-102.2.0esr-12.0-2 branch:

• New Identity ( d627ac1c )
• Security Level/Slider ( 231b7a82 )
• New User Onboarding ( 5b6d65d6 )
• Letterboxing ( bb3ee4b7 )
• Crypto Safety ( b2f764ca )
• Profile Access Error Messages ( b924418a )
• External App Helper Dialog ( ba292b8b, but also in torbutton.git )
• about:preferences additions ( a245f127 )
• TorConnect captive portal/tor bootstrapping ( 777c84f5 )
• Tor Browser Updater ( 413ad7d4 )
• about:tbupdate changleog ( d15354ca )
• Onion Service specific URLbar icons+dialog changes ( a940145e )
• V3 Onion Service Auth prompt ( 422ba974 )
• Onion Location ( 46a0c98c )
• Integrated Tor Browser Manual ( 8e4a269d )
• Circuit Display Dropdown ( torbutton.git )
• about:tor page ( torbutton.git )
• about:rulesets ( f1b77124 ) ( thanks @pierov )

@pierov @duncan feel free to add to this list as I'm sure something's been forgotten

I will also send this ticket to some screen-reader users that have helped us in the past with testing for their input on nay known pain-points.

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

added Accessibility Sponsor 131 Q4 UX labels

assigned to @henry

marked this issue as related to #16250 (closed)

marked this issue as related to #32274 (closed)

marked this issue as related to #27503 (closed)

I think we could fix also about:rulesets, now that we're at it, but with very low priority.

added Doing label

changed the description

marked this issue as related to #41290 (closed)

marked the checklist item New Identity ( d627ac1c ) as completed

marked the checklist item Security Level/Slider ( 231b7a82 ) as completed

marked the checklist item New User Onboarding ( 5b6d65d6 ) as completed

marked this issue as related to #41305

marked the checklist item Letterboxing ( bb3ee4b7 ) as completed

mentioned in issue #16250 (closed)

marked this issue as related to #41363 (closed)

marked the checklist item Crypto Safety ( b2f764ca ) as completed

marked the checklist item Profile Access Error Messages ( b924418a ) as completed

marked the checklist item External App Helper Dialog ( ba292b8b, but also in torbutton.git ) as completed

marked the checklist item about:preferences additions ( a245f127 ) as completed

marked this issue as related to #41383

marked this issue as related to #41384

marked the checklist item TorConnect captive portal/tor bootstrapping ( 777c84f5 ) as completed

marked the checklist item Tor Browser Updater ( 413ad7d4 ) as completed

marked this issue as related to #41393 (closed)

marked the checklist item about:tbupdate changleog ( d15354ca ) as completed

marked the checklist item Onion Service specific URLbar icons+dialog changes ( a940145e ) as completed

marked this issue as related to #41408

marked the checklist item V3 Onion Service Auth prompt ( 422ba974 ) as completed

Note: I'm currently just going through looking for obvious semantic issues and testing the screen reader output. I'll investigate High Contrast afterwards, maybe in the linked issues or in #22409

I can test with Large Text as well.

marked the checklist item Onion Location ( 46a0c98c ) as completed

marked this issue as related to #41411

marked this issue as related to #41421

marked the checklist item Integrated Tor Browser Manual ( 8e4a269d ) as completed

marked this issue as related to #41422

marked the checklist item Circuit Display Dropdown ( torbutton.git ) as completed

marked the checklist item about:tor page ( torbutton.git ) as completed

marked this issue as related to #41423 (closed)

marked the checklist item about:rulesets ( f1b77124 ) ( thanks @pierov ) as completed

marked this issue as related to #41425

marked this issue as related to #22409

ok, I've gone through each listed component. I only tested with Orca, so there may be some other problems that are screen reader specific. I have NVDA set up on my windows virtual machine so I can also test with that. But for now I think the linked issue give a good idea on which parts could do with some revision.

@richard what is the next step? Start going through each linked issue and putting in patches?

@henry we should try and fix as many as possible before 12.0 with a priority on functionality common to privacy browser and tor browser, before we switch over to privacy browser focused stuff in December.

added Meta label

added Desktop label

added Q1 label and removed Q4 label

added Q2 label and removed Q1 label

added Roadmap::Future label and removed Doing label

removed Q2 label