Crypto warning popup is not screen reader accessible

added Accessibility UX labels

marked this issue as related to #41280

added Sponsor 131 label

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

changed milestone to %Sponsor 131 - Phase 2 - Privacy Browser

added Bug label

added Roadmap::Future label

added Desktop label

marked this issue as related to #41351 (closed)

@duncan can I have some UX insight?

Not moving focus into the popup, even though it requires a response. This means you cannot navigate it with a screen reader in "browse" mode.

This crypto warning uses a popup notification. I spoofed the notification here

I think this is a misuse of the popup notification.

The firefox code is written so that the popup notification is noticed, but can be ignored without interruption. For keyboard and screen reader users, this means they will get an alert that reads out the heading but will not move focus so that the user can continue what they are doing. They can optionally jump into the alert box by pressing F6. This is because the firefox alerts are either shown in reaction to what a web page does (permissions popup), or are triggered by some user action but can be ignored (saved password popups).

This crypto alert doesn't really fit because this is in direct response to the user action, and it seems that the intention of the original issue #40209 (closed) was that it shouldn't be ignored. So it seems that a modal dialog would be more suitable. What do you think? Or would that be too annoying?

Also, the "Learn More" link currently just goes to https://support.torproject.org/ because I think the discussed support page was never made. Do we actually have a dedicated link for users to learn more?

Also, the "What can you do about it?" bold text seems unnecessary and the wrong tone. Should I just drop it?

PS, I'm already going to address the wrong accesskey ("B" instead of "D") and styling issues in the screenshot.

I think you've convinced me! Like so?

I think you've convinced me! Like so?

Yes, something like that. I think as a first step I might just use the current string with the generic prompt framework. The main difference would be there would no read-only input to show the copied text, it would still be shown in brackets. Once that is done we can see whether it is worth creating a new custom dialog for this.

No worries, that makes sense.

Also, the "Learn More" link currently just goes to https://support.torproject.org/ because I think the discussed support page was never made. Do we actually have a dedicated link for users to learn more?

I think so, too. We have an issue about fixing various Firefox support link (#40899), but it includes a few pages I'd like to add to the manual.

Let me add also this to a comment to raise the priority it remains in our radar .