Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 876
    • Issues 876
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

GitLab has been upgraded GitLab 16, please report any issues!

  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #41722
Closed
Open
Issue created Apr 07, 2023 by Thorin@thorin👣Reporter

Regression: window maximization warning cannot be closed by the X button

following on from #41561 (closed) @ma1

TB

  • flip letterboxing off
  • note: extensions.torbutton.maximize_warnings_remaining = 3
  • go full screen
  • warning does not show (I am not on an HTTPS origin)
  • F11 to restore - now the warning shows
  • if maximizing instead of FS, it works fine
  • ToDo?: suppress the warning in exiting FS or make the warning show in FS
  • ToDo?: OK vs X is confusing - X reduces the count, OK doesn't - this seems backwards (but I can see both sides) - anyway, it seems to confuse users. OK means the user (likely read the message and) acknowledged the warning, X means they ignored it and decided to not take action, so IMO this is backwards.

MB

  • the same issues above would apply since it is based on TB
  • but we also have https://github.com/mullvad/mullvad-browser/issues/44
  • here the warning pref doesn't exist and the message cannot be dismissed via X only via Restore button
  • also why is MB using Restore and TB using OK as strings?

Flip your LBing pref back on, people!

Honestly, why have the X button at all? Seems convoluted :)

Edited Apr 07, 2023 by Thorin
Assignee
Assign to
Time tracking