Review Mozilla 1854965: Define new search engine configuration schema

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1854965

We should ensure our added search-providers still work as expected.

marked this issue as related to tor-browser-spec#40069 (closed)

added 14.0 stable All Platforms Next Task FF128-esr labels

marked this issue as related to #41835 (closed)

We should ensure our added search-providers still work as expected.

They don't .

I think this is Desktop though, not Android, as IIRC Android has its own definitions.

So, I added only DDG and DDG onion. For the rest, this is blocked on #41835 (closed).

mentioned in issue #41835 (closed)

added Backlog label

removed Backlog label

mentioned in issue #43082 (closed)

assigned to @pierov

removed All Platforms label

added Desktop label

marked this issue as related to #43082 (closed)

added Doing label and removed Next label

I'm starting to question if the work we do in 6f3c0d2f is actually useful.

We delete a lot of stuff, but a lot of other things remain.

If the old extensions aren't even needed, we could remove the browser/components/search/extensions from jar.mn instead (seems smarter).

mentioned in merge request !1162 (merged)

Yesterday's MR fixed the search engine problems, and they will skip this schema, more or less, but I decided to investigate a little bit more.

The initial implementation was in 179d2c89, then the file (toolkit/components/search/schema/search-engine-config-v2-schema.json) has been renamed in 5aacd4b8 to toolkit/components/search/schema/search-config-v2-schema.json.

In general, there are a few other schemas in toolkit/components/search/schema, but they don't seem to be too complex. The JSON I added to the MR doesn't pass search-config-v2-schema.json, but I'm for a YOLO approach to it (it works, it's enough for me).

So, this Bug itself was not that worrying/we bypass it if we use this approach. However, I checked also the related Bugs, and found these ones:

• Bug 1833829: the search-config-v2 meta
• Bug 1870686: the post-search-config-v2 meta
• Bug 1818323: "Search engine configuration parity with Desktop": it seems the goal was to apply the same config also to Android (!)

The most interesting (public) bug seems to be Bug 1885953, which is about deleting former web extensions (not solved yet). I'm following it on Bugzilla, I'll follow up also with a new issue downstream.

Finally, there are a couple of bugs for Android, one to get the remote settings data in AC (solved), and one I haven't exactly understood, but that hasn't been solved yet.

mentioned in issue #43111

marked this issue as related to #43111

marked this issue as related to #43113 (closed)

marked this issue as related to tor-browser-build#41219 (closed)