Year End Campaign YEC 2024 for desktop

Merge Info

Related Issues

• #43098 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

Implement YEC 2024 for desktop.

How Tested

Either edit AboutTorParent.sys.mjs to change yecStartDate and hideYEC, or in "about:tor" set YecWidget.messageNumber to 0, 1 or 2.

requested review from @morgan

assigned to @henry

NOTE: This is in draft because I still need to test a few aspects, and there are some changes due in figma. I'm not expecting to make any major changes for the final draft. But since I'm away wednesday and thursday, I thought I would share this in case there is any early feedback, or anyone wants to try it out.

/cc @donuts @felicia @nicob

Initial screenshots:

And the dynamic sizing:

Recording of the campaign banner in about:tor, making the window width smaller

NOTE: I deviated from the figma design by making the title text centre-aligned when in the smaller format (like android) because the right-aligned text with text-wrap-style: balanced looked awkward, and without the balanced text the background paint didn't look as good.

This looks great!

marked the checklist item Eventually: patchset that needs to be verified in alpha before backport as incomplete

added 26 commits

• 496b5d7c...a36c4f1c - 25 commits from branch tpo/applications:tor-browser-128.2.0esr-14.0-1
• bf4e922e - Bug 43098: Year End Campaign 2024.

Compare with previous version

added 15 commits

• bf4e922e...f5f0ab07 - 14 commits from branch tpo/applications:tor-browser-128.2.0esr-14.0-1
• fbcd8460 - Bug 43098: Year End Campaign 2024.

Compare with previous version

added 18 commits

• fbcd8460...dbe52600 - 17 commits from branch tpo/applications:tor-browser-128.2.0esr-14.0-1
• 5535b88d - Bug 43098: Year End Campaign 2024.

Compare with previous version

added 1 commit

• 7df4863c - Bug 43098: Year End Campaign 2024.

Compare with previous version

@henry you probably saw this in the android ticket but wanted to document here as well for posterity. @donuts shared that we got concerning feedback from users about the banner populating on every new tab, so we're going to follow their recommendation of hiding the banner after being dismissed, and only showing up again once a new session starts or after an update!

mentioned in issue #43099 (closed)

mentioned in merge request !1202 (closed)

added 6 commits

• 7df4863c...13a575c8 - 5 commits from branch tpo/applications:tor-browser-128.2.0esr-14.0-1
• 8ebc6cfc - Bug 43098: Year End Campaign 2024.

Compare with previous version

added 1 commit

• 9f78be11 - Bug 43098: Year End Campaign 2024.

Compare with previous version