BB 41051: Replace Noto Sans Myanmar with Pyidaungsu.

Merge Info

Issues

Resolves

• #41051 (closed)
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Related

• #41932
• mullvad-browser#xxxxx
• tor-browser-build#41401 (closed)

Merging

Target Branches

• tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

• Alpha: esr128-14.5
• Stable: esr128-14.0
• Legacy: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Upstream

• Patchset is a candidate for uplift to Firefox
• Patchset is a backport from Firefox
  • Bugzilla link:
  • Upstream commit:

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov - lol, I'll review myself
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

Change Description

Replace Noto Sans Myanmar with Pyidaungsu as per the resolved/related issues.

How Tested

Testbuild: https://tb-build-03.torproject.org/~pierov/torbrowser/alpha/unsigned/14.5a4-build234/tor-browser-linux-x86_64-14.5a4.tar.xz

sans-serif will be replaced with the new font (but sadly the widget fonts won't)

added Apps::Type::Investigation Desktop Fonts Localization Sponsor 131 Roadmap::Future Task labels

assigned to @pierov

marked this merge request as draft

marked this merge request as ready

Notice that this doesn't resolve #41932.

For that we'll need to investigate the font code a bit more, as Firefox chooses Noto Serif over Pyidaungsu for widget fonts.

However, Pyidaungsu will be a better choice than Noto Sans anyway, so I'd be up to choose it.

A possibility is also we drop Noto Serif Myanmar, but it's UI vs. sites at this point.

requested review from @morgan

changed the description

mentioned in merge request tor-browser-build!1176 (merged)

approved this merge request

merged

• cherry-pick'd to base-browser as 65d71c24
• cherry-pick'd to mullvad-browser mullvad-browser@774a8aed

removed Roadmap::Future label