Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,005
    • Issues 1,005
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor Browser
  • Merge requests
  • !254

Draft: Bug 40773&40774: update about:torconnect and about:preferences#tor

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Pier Angelo Vendrame requested to merge pierov/tor-browser:bug_40773_74 into tor-browser-91.6.0esr-11.5-1 Feb 10, 2022
  • Overview 60
  • Commits 24
  • Changes 37

These patches should close #40773 (closed) and #40774 (closed).

However there are still some points I would like to discuss/comment:

  • about Bridge cards:
    • hash+dictionary instead as names:
      • should we have a name generated in this way also for Meek/Snowflake transport, since they can be shared?
      • can I just implement this in TB code, or do we want to do a shared implementation with other projects, like BridgeDB?
    • can I drop changes for the "secret" bridge label?
      • since, from what I understood, we are going to use only the transport, as a label
  • the online test is now on Moat.jsm, and torPane.js calls it directly, but in this way the previous test outcome is reset when you reload the page
    • Possible workaround: move the connection status to TorConnect, but I am not sure it is the best thing to do...
  • error strings for Moat are still missing. We have a field for detailed description that I feel we should provide from the request itself (instead of returning {}/null)
  • what about the debug stuff? In case we keep it, we need to update also tor-launcher for the new _torBootstrapDebugSetError()
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bug_40773_74