Skip to content
Snippets Groups Projects

maint/thanks: Include some git trailers in acknowledgments

Merged maint/thanks: Include some git trailers in acknowledgments
nickm/arti:thanks_trailer into main
1 unresolved thread
Merged Nick Mathewson requested to merge nickm/arti:thanks_trailer into main
1 unresolved thread

When building our list of acknowledgments, previously we would only include author and committer names.

Now we also include anybody listed in the "Reported-by", "Co-authored-by", and "Thanks" trailers.

This will be helpful so that we don't forget to acknowledge people who (for example) report security issues.

Merge request reports

Approved by
Ian Jackson

Merged by Ian JacksonIan Jackson 1 year ago (May 23, 2023 12:33pm UTC)

Merge details

  • Changes merged into main with b15ca027.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
maint/thanks
12
10 13 TEMPDIR=$(mktemp -d)
11 14 TO_EXCLUDE="$(dirname "$0")/exclude_contributors.txt"
12 15 LAST_REV=$1
13 16
17 WE_CREDIT=(
18 # Name of the author.
19 %an
20 # Name of the committer.
21 %cn
22 # Anybody in Reported-by. (These are case-insensitive, don't worry.)
23 "%(trailers:valueonly=true,key=Reported-by)"
24 # Anybody in Co-Authored-By.
25 "%(trailers:valueonly=true,key=Co-Authored-by)"
26 # Anybody in Thanks.
27 "%(trailers:valueonly=true,key=Thanks)"
  • Ian Jackson
    Ian Jackson @Diziet ·
    Maintainer

    LGTM. I have one question. If you think the answer is "no", please just merge this. Otherwise, I guess, please add another commit and I'll re-review. (The repetition of the trailers:valueonly stuff is starting to get a bit vexing imo...)

  • Ian Jackson approved this merge request

    approved this merge request

  • Nick Mathewson added 1 commit

    added 1 commit

    • 407a9280 - thanks: Also acknowledge Suggested-By

    Compare with previous version

  • Ian Jackson mentioned in commit b15ca027

    mentioned in commit b15ca027

  • Ian Jackson merged

    merged

    • Please register or sign in to reply