Skip to content
Snippets Groups Projects

Provide isolate-all-streams function

Merged Ian Jackson requested to merge Diziet/arti:always-isolate into main
2 unresolved threads

Fixes #279 (closed)

This branch is on top of the one for !250 (merged) "Provide TorClient::set_default_prefs and clone_with_prefs". Any changes in response to review there are not likely to conflict with this I think.

Merge request reports

Approval is optional

Merged by Ian JacksonIan Jackson 3 years ago (Jan 20, 2022 7:08pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
94 94 None,
95 95 /// Id of the isolation group the connection should be part of
96 96 Explicit(IsolationToken),
97 /// Isolate every connection!
98 EveryConnection,
  • Nick Mathewson
  • Nick Mathewson
    Nick Mathewson @nickm started a thread on an outdated change in commit 9e904167
  • 211 213 self
    212 214 }
    213 215
    216 /// Indicate that no connection should share a circuit with any other.
    217 ///
    218 /// **Use with care:** This is likely to have poor performance, and imposes a much greater load
    219 /// on the Tor network. Use this option only to make small numbers of connections each of
    220 /// which need very high levels of privacy.
    221 ///
    222 /// This can be undone by calling `set_isolation_group` or `new_isolation_group` on these
    223 /// preferences.
    224 pub fn isolate_every_connection(&mut self) -> &mut Self {
  • I've added some suggested naming and documentation tweaks; otherwise this looks great.

  • Ian Jackson added 1 commit

    added 1 commit

    • 06c15f21 - isolation: Much better wording for always isolate setting

    Compare with previous version

  • mentioned in commit Diziet/arti@7bc89417

  • mentioned in commit Diziet/arti@23c1fc8c

  • Ian Jackson added 2 commits

    added 2 commits

    • 23c1fc8c - isolation: Rename (internal) EveryStream enum variant
    • 7bc89417 - isolation: Rename isolate_every_stream from ..._connection

    Compare with previous version

  • Ian Jackson enabled an automatic merge when the pipeline for 7bc89417 succeeds

    enabled an automatic merge when the pipeline for 7bc89417 succeeds

  • mentioned in commit Diziet/arti@41ec94c9

  • Ian Jackson mentioned in merge request !256 (merged)

    mentioned in merge request !256 (merged)

  • merged

  • Ian Jackson mentioned in commit 695a33c1

    mentioned in commit 695a33c1

  • mentioned in commit Diziet/arti@aa4d8de1

  • Please register or sign in to reply
    Loading