FallbackDir: orports: Introduce and use VecBuilder

This is part of #447 (closed) and therefore #371 (closed) and #285 (closed)

Found with

git-ls-files | xargs perl -ne 'next unless m/^\#.*derive.*Builder/..m/^\}/; print "$ARGV:$.:$_"' 2>&1 |less +/':.*Vec'

assigned to @Diziet

requested review from @nickm

Is this overkill? As I understood it, the rationale for using FooListBuilder only applied when Foo itself was constructed using a FooBuilder. But we don't have a SocketAddrBuilder, and we don't plan to.

I don't know if it's overkill. Maybe we just want to let derive_builder do its thing on a Vec.

But, this branch removes an ad-hoc appender, FallbackDirBuilder::orport. Definitely we shouldn't have such a thing. Either it should be a completely vanilla Vec which you can only set all in one go, or it should be a FooListBuilder.

I did the latter because it seemed better to be like all the other lists.

mentioned in merge request !475 (merged)

@Diziet Let's chat on Friday about these. I'm generally wondering whether this whole "FooListBuilder" pattern is really better than just exposing a &mut Vec<Foo> (or &mut OtherContainer<Foo> as appropriate) from the Builder. But we should decide one way or another on the soon side, so I don't keep blocking you on this.

Mergeable, but see #451 (closed) for the fix we want to do immediately afterwards.

approved this merge request

mentioned in merge request !481 (merged)

marked this merge request as draft

added 80 commits

• 4dcd67a3...ab979b0b - 72 commits from branch tpo/core:main
• 0c001ed6 - list_builder: Actually honour attributes
• 578684f2 - list_builder: Make helper capable of handling generics
• 221fe634 - list_builder: Use Educe to derive Default
• 2487a46e - list_builder: Provide VecBuilder
• 4262a440 - list_builder: Update semver note
• 6791758d - FallbackDir: Do not consider defaulted-empty orport list to be valid
• cc394ca9 - FallbackDir: Do orport validation after autogenerated build
• 4ad4cae4 - FallbackDir: Use VecBuilder for orports

Compare with previous version

marked this merge request as ready

@nickm now rebased on !481 (merged). This also contains some enhancements to !481 (merged) and one bugfix. I think it needs your re-review. Thanks.

changed title from FallbackDir: orports: Introduce and use SocketAddrListBuilder to FallbackDir: orports: Introduce and use VecBuilder

This LGTM now; I have noted a couple of minor issues. Once you've looked at those, feel free to merge.

mentioned in issue #452 (closed)

added 1 commit

• cb892116 - Fix typo

Compare with previous version

mentioned in commit Diziet/arti@df2813ed

added 1 commit

• df2813ed - list_builder: Add some xrefs about macro_rules limitations

Compare with previous version

Thanks. Will set this to merge.

resolved all threads

enabled an automatic merge when the pipeline for df2813ed succeeds

merged

mentioned in commit a334f172

mentioned in issue #447 (closed)