GuardUsage: restrictions: Use list builder

Although these do not appear in the config, it seems sensible to get rid of what I think is the remaining ad-hoc list manipulation site.

define_list_config_builder requires that the builder element type be Deserialize. Currently GuardUsageRestriction is a transparent, public enum, so we aren't really exposing anything.

We could introduce GuardUsageRestrictionBuilder now, but since it's not in the config and thereofore only in the public API of the lower crates, we can definitely put that off.

This is part of somewhat related to #447 (closed) and therefore #371 (closed) and #285 (closed)

Found with

git-ls-files | xargs perl -ne 'next unless m/^\#.*derive.*Builder/..m/^\}/; print "$ARGV:$.:$_"' 2>&1 |less +/':.*Vec'

assigned to @Diziet

requested review from @nickm

I don't think this is actually part of #447 (closed)? These aren't configuration types.

I'm going to think about this one for a little...

You're right, they aren't configuration types.

However, I definitely think we need to get rid of the ad-hoc list-appender, push_restriction. I think similar arguments apply as in !474 (comment 2798507)

changed the description

Mergeable, but see #451 (closed) for the fix we want to do immediately afterwards.

approved this merge request

mentioned in merge request !481 (merged)

marked this merge request as draft

added 71 commits

• af1b85ab...9214eb5d - 70 commits from branch tpo/core:main
• 15ff9e56 - GuardUsage: restrictions: Use list builder

Compare with previous version

marked this merge request as ready

@nickm This is now rebased on top of !481 (merged) (the new list builder). Would you please check you're still happy with it?

added 3 commits

• 15ff9e56...ab979b0b - 2 commits from branch tpo/core:main
• 015db3d7 - GuardUsage: restrictions: Use list builder

Compare with previous version

added 1 commit

• c84d6091 - GuardUsage: restrictions Add semver note

Compare with previous version

Yes, I like this. Marking for merge!

enabled an automatic merge when the pipeline for c84d6091 succeeds

merged

mentioned in commit 019b3b9c

mentioned in issue #447 (closed)