Do backtrace string matching test only on Linux
"Fixes" #455 (closed) by suppressing the test.
CC @wiz
Merge request reports
Activity
assigned to @Diziet
mentioned in issue #455 (closed)
requested review from @eta
250 250 mod test { 251 251 use super::*; 252 252 253 // We tet this on Linux only. This test case is to ensure that we are using the changed this line in version 2 of the diff
250 250 mod test { 251 251 use super::*; 252 252 253 // We tet this on Linux only. This test case is to ensure that we are using the 254 // backtrace module correctly, etc., which can be checked by doing it on one platform. 255 // Doing it on others simply exposes us to the vagaries of platform backtrace support. 256 // Arti ought not to fail its tests just because someone is using a platform with poor. changed this line in version 2 of the diff
Hi. (I did wonder what had happened to this MR as it vanished off my gitlab thingy)
If we want to end-to-end test the Rust backtrace module we could do that. I don't think it's a good idea to do it on all platforms by default. That would expose us to random lossage on lower-tier Rust platforms. Evidently we don't think it's our job to go and fix the platforms and there's nothing much we can do in our code to work around it.
How about I add the strings for OSX and Windows, explicity?
mentioned in commit d69fc2fa
mentioned in commit 9d8ce432
Whoops, hit merge too quickly (and had to revert). @Diziet, would you mind addressing nickm's query (and then feel free to merge when you've done that)?
mentioned in merge request !512 (merged)
