Clean up some errors in tor-dirmgr
1 unresolved thread
1 unresolved thread
This branch cleans up some error messages and types in tor-dirmgr to be more informative.
I'm marking this as Draft because we shouldn't merge it before resolving #521 (closed) and putting out a tor-dirmgr patch release.
There are a couple of bigger refactorings that I am not doing right now:
- Including full DocSource information in every error that comes from a document.
- Describing what kind of a document we were trying to get in every applicable error.
- Separating the errors that apply only to a single bootstrap-driven operation from those that refer to an API-level call.
I think those would all be fine down the line, but they make more sense after other planned dirmgr refactoring like #433.
Edited by Nick Mathewson
Merge request reports
Activity
assigned to @nickm
requested review from @Diziet
92 93 } 93 94 } 94 95 95 let mut lockfile = fslock::LockFile::open(&lockpath)?; 96 if !readonly && !lockfile.try_lock()? { 96 let mut lockfile = 97 fslock::LockFile::open(&lockpath).map_err(|e| Error::LockFile(Arc::new(e)))?; changed this line in version 2 of the diff
added 1 commit
- 3c424c82 - dirmgr: Add a helper to create LockFile errors.
enabled an automatic merge when the pipeline for 3c424c82 succeeds
mentioned in commit 8d66f8ec
Please register or sign in to reply